optimize: modify the parameter name in refreshToken method #7608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7608 +/- ##
============================================
+ Coverage 61.17% 61.22% +0.04%
Complexity 654 654
============================================
Files 1310 1310
Lines 49567 49567
Branches 5836 5836
============================================
+ Hits 30322 30345 +23
+ Misses 16542 16514 -28
- Partials 2703 2708 +5
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
added a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
I found that when integrating with Seata's built-in NamingServer, the refreshToken method in the register process incorrectly uses the TC address as its parameter. In fact, the token should be refreshed using the NamingServer address itself. I fixed this by updating the method signature and calls to refreshToken(String namingServerAddress) to correctly reflect the actual parameter meaning.
对接自身的namingServer时，
refreshToken方法的形参字面意思上应该是注册中心本身的地址 而不是TC 地址Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews