Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@whaon
Copy link
Contributor

@whaon whaon commented Sep 5, 2025

…er to the last,so it can override the io.seata.saga.rm.SagaResourceManager

Ⅰ. Describe what this PR did

adjust the order of org.apache.seata.saga.rm.SagaResourceManager to the last, so it can override the io.seata.saga.rm.SagaResourceManager

Ⅱ. Does this pull request fix one issue?

fix #7108

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…er to the last,so it can override the io.seata.saga.rm.SagaResourceManager
@funky-eyes funky-eyes requested a review from xjlgod September 8, 2025 03:28
@YongGoose
Copy link
Member

Please fix failing test

Error:    SPITest.testRmSPIOrder:39 expected: <io.seata.saga.rm.SagaResourceManager> but was: <org.apache.seata.saga.rm.SagaResourceManager>

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.01%. Comparing base (3062b72) to head (1e36819).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #7622   +/-   ##
=========================================
  Coverage     61.01%   61.01%           
  Complexity      666      666           
=========================================
  Files          1316     1316           
  Lines         49804    49804           
  Branches       5855     5855           
=========================================
  Hits          30388    30388           
- Misses        16703    16707    +4     
+ Partials       2713     2709    -4     
Files with missing lines Coverage Δ
.../org/apache/seata/saga/rm/SagaResourceManager.java 8.16% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@whaon
Copy link
Contributor Author

whaon commented Sep 11, 2025

Finished @YongGoose

Copy link
Contributor

@xjlgod xjlgod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xjlgod xjlgod merged commit cb45125 into apache:2.x Sep 13, 2025
10 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
…ge (apache#7622)

* bugfix:adjust the order of org.apache.seata.saga.rm.SagaResourceManager to the last,so it can override the io.seata.saga.rm.SagaResourceManager

* bugfix:fix unittest error

---------

Co-authored-by: tonghao <[email protected]>
Co-authored-by: Jingliu <[email protected]>
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
…ge (apache#7622)

* bugfix:adjust the order of org.apache.seata.saga.rm.SagaResourceManager to the last,so it can override the io.seata.saga.rm.SagaResourceManager

* bugfix:fix unittest error

---------

Co-authored-by: tonghao <[email protected]>
Co-authored-by: Jingliu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saga branch rollback retry in tm will cause null NullPointerException because StateMachineEngineHolder can not get getStateMachineEngine

3 participants