Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@YvCeung
Copy link
Contributor

@YvCeung YvCeung commented Sep 19, 2025

Ⅰ. Describe what this PR did

Simplify the user's configuration of transport.server and transport.type, and the system automatically identifies whether epoll is available

discussion #7634

Ⅱ. Does this pull request fix one issue?

fix #7620

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@YvCeung YvCeung closed this Sep 19, 2025
@YvCeung YvCeung reopened this Sep 19, 2025
@xjlgod
Copy link
Contributor

xjlgod commented Sep 20, 2025

The ci was not passed, and please add docs.

@xjlgod
Copy link
Contributor

xjlgod commented Sep 20, 2025

Confirm whether NettyServerBootstrap also needs to be modified

@YvCeung
Copy link
Contributor Author

YvCeung commented Sep 20, 2025

Confirm whether NettyServerBootstrap also needs to be modified

I have checked it and there is no need to make any modifications

@YvCeung YvCeung closed this Sep 20, 2025
@YvCeung YvCeung reopened this Sep 20, 2025
@codecov
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.04%. Comparing base (7accdf8) to head (bf6ae07).
⚠️ Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...g/apache/seata/core/rpc/netty/NettyBaseConfig.java 0.00% 0 Missing and 3 partials ⚠️
...che/seata/core/rpc/netty/NettyClientBootstrap.java 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #7645   +/-   ##
=========================================
  Coverage     61.04%   61.04%           
  Complexity      666      666           
=========================================
  Files          1316     1314    -2     
  Lines         49819    49760   -59     
  Branches       5858     5849    -9     
=========================================
- Hits          30411    30377   -34     
+ Misses        16700    16681   -19     
+ Partials       2708     2702    -6     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...apache/seata/core/rpc/netty/NettyClientConfig.java 54.16% <ø> (+0.74%) ⬆️
...g/apache/seata/core/rpc/netty/NettyBaseConfig.java 78.78% <0.00%> (+30.96%) ⬆️
...che/seata/core/rpc/netty/NettyClientBootstrap.java 60.00% <50.00%> (+3.75%) ⬆️

... and 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YvCeung YvCeung closed this Sep 22, 2025
@YvCeung YvCeung reopened this Sep 22, 2025
Copy link
Contributor

@xjlgod xjlgod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.6.0 milestone Sep 24, 2025
@funky-eyes funky-eyes merged commit cb3e99b into apache:2.x Sep 24, 2025
9 of 10 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung added a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kqueue incompatible event loop NioEventLoop

3 participants