-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize:simplifying the relevant transport.* configuration types #7645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The ci was not passed, and please add docs. |
|
Confirm whether NettyServerBootstrap also needs to be modified |
I have checked it and there is no need to make any modifications |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 2.x #7645 +/- ##
=========================================
Coverage 61.04% 61.04%
Complexity 666 666
=========================================
Files 1316 1314 -2
Lines 49819 49760 -59
Branches 5858 5849 -9
=========================================
- Hits 30411 30377 -34
+ Misses 16700 16681 -19
+ Partials 2708 2702 -6
🚀 New features to boost your workflow:
|
xjlgod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Simplify the user's configuration of transport.server and transport.type, and the system automatically identifies whether epoll is available
discussion #7634
Ⅱ. Does this pull request fix one issue?
fix #7620
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews