Merge pull request #8 from sede-open/task/exclude-views-from-get-table-names

PeterDKay · web-flow · commit a799ee75ba04 · 2023-08-07T20:48:59.000+01:00
Removed commented out old method
diff --git a/src/databricks/sqlalchemy/dialect/__init__.py b/src/databricks/sqlalchemy/dialect/__init__.py
@@ -259,28 +259,12 @@ def get_table_names(self, connection, schema=None, **kwargs):
                          AND table_type = 'MANAGED';""".format(
                 schema_str
             )
+            # TODO: Add if scenario for None schema
             data = cur.execute(sql_str).fetchall()
             _tables = [i[TABLE_NAME] for i in data]
 
         return _tables
 
-    # TODO: Commented out this until can be deleted after successful tests
-    # def get_table_names(self, connection, schema=None, **kwargs):
-    #     TABLE_NAME = 1
-    #     catalog = "`" + self.catalog + "`"
-    #     schema = ("`" + schema + "`") or ("`" + self.schema + "`")
-    #
-    #     with self.get_driver_connection(
-    #         connection
-    #     )._dbapi_connection.dbapi_connection.cursor() as cur:
-    #         sql_str = "SHOW TABLES FROM {}".format(
-    #             ".".join([catalog, schema])
-    #         )
-    #         data = cur.execute(sql_str).fetchall()
-    #         _tables = [i[TABLE_NAME] for i in data]
-    #
-    #     return _tables
-
     def get_view_names(self, connection, schema=None, **kwargs):
         VIEW_NAME = 1
         with self.get_driver_connection(
