Add destination specific options (#80)

dailycoding · f2prateek · commit 0632de5d6422 · 2018-03-19T13:12:58.000-07:00
* Enable destination specific options

* Add test cases for destination specific option

* Add missing test function Identify for Net35
diff --git a/Analytics/Model/Options.cs b/Analytics/Model/Options.cs
@@ -73,5 +73,25 @@ public Options SetIntegration (string integration, bool enabled)
 			return this;
 		}
 
+		/// <summary>
+		/// Enable destination specific options for integration.
+		/// For example, to send tags in https://segment.com/docs/destinations/vero/#tags, use following
+		///   new Options()
+		///     .Integration("Vero", new Model.Dict() {
+		///			"tags", new Model.Dict() {
+		///             { "id", "235FAG" },
+		///             { "action", "add" },
+		///             { "values", new string[] {"warriors", "giants", "niners"} }
+		///         }
+		///     });
+		/// </summary>
+		/// <param name="integration">The integration name.</param>
+		/// <param name="value">Dict value</param>
+		public Options SetIntegration (string integration, Dict value)
+		{
+			this.Integrations.Add (integration, value);
+			return this;
+		}
+
 	}
 }
diff --git a/Test.Net35/ActionTests.cs b/Test.Net35/ActionTests.cs
@@ -1,4 +1,4 @@
-using System;
+﻿using System;
 using NUnit.Framework;
 using System.Collections.Generic;
 using System.Threading.Tasks;
@@ -24,6 +24,27 @@ public void IdentifyTestNet35()
 			FlushAndCheck(1);
 		}
 
+		[Test()]
+		public void IdentifyWithCustomOptionsTestNet35()
+		{
+			var traits = new Model.Traits() {
+				{ "email", "friends@segment.com" }
+			};
+			var options = new Model.Options()
+				.SetIntegration("Vero", new Model.Dict() {
+					{
+						"tags", new Model.Dict() {
+							{ "id", "235FAG" },
+							{ "action", "add" },
+							{ "values", new string[] {"warriors", "giants", "niners"} }
+						}
+					}
+				});
+
+			Actions.Identify(Analytics.Client, traits, options);
+			FlushAndCheck(1);
+		}
+
 		[Test()]
 		public void TrackTestNet35()
 		{
diff --git a/Test.Net35/Actions.cs b/Test.Net35/Actions.cs
@@ -49,6 +49,12 @@ public static void Identify(Client client)
 			Analytics.Client.Flush();
 		}
 
+		public static void Identify(Client client, Traits traits, Options options)
+		{
+			client.Identify("user", traits, options);
+			Analytics.Client.Flush();
+		}
+
 		public static void Group(Client client)
 		{
 			client.Group("user", "group", Traits(), Options());
diff --git a/Test.Net45/ActionTests.cs b/Test.Net45/ActionTests.cs
@@ -1,4 +1,4 @@
-using System;
+﻿using System;
 using NUnit.Framework;
 using System.Collections.Generic;
 using System.Threading.Tasks;
@@ -24,6 +24,27 @@ public void IdentifyTestNet45()
 			FlushAndCheck(1);
 		}
 
+		[Test()]
+		public void IdentifyWithCustomOptionsTestNet45()
+		{
+			var traits = new Model.Traits() {
+				{ "email", "friends@segment.com" }
+			};
+			var options = new Model.Options()
+				.SetIntegration("Vero", new Model.Dict() {
+					{
+						"tags", new Model.Dict() {
+							{ "id", "235FAG" },
+							{ "action", "add" },
+							{ "values", new string[] {"warriors", "giants", "niners"} }
+						}
+					}
+				});
+
+			Actions.Identify(Analytics.Client, traits, options);
+			FlushAndCheck(1);
+		}
+
 		[Test()]
 		public void TrackTestNet45()
 		{
diff --git a/Test.Net45/Actions.cs b/Test.Net45/Actions.cs
@@ -49,6 +49,12 @@ public static void Identify(Client client)
 			Analytics.Client.Flush();
 		}
 
+		public static void Identify(Client client, Traits traits, Options options)
+		{
+			client.Identify("user", traits, options);
+			Analytics.Client.Flush();
+		}
+
 		public static void Group(Client client)
 		{
 			client.Group("user", "group", Traits(), Options());
diff --git a/Test/ActionTests.cs b/Test/ActionTests.cs
@@ -24,6 +24,27 @@ public void IdentifyTest()
 			FlushAndCheck(1);
 		}
 
+		[Test()]
+		public void IdentifyWithCustomOptionsTest()
+		{
+			var traits = new Model.Traits() {
+				{ "email", "friends@segment.com" }
+			};
+			var options = new Model.Options()
+				.SetIntegration("Vero", new Model.Dict() {
+					{
+						"tags", new Model.Dict() {
+							{ "id", "235FAG" },
+							{ "action", "add" },
+							{ "values", new string[] {"warriors", "giants", "niners"} }
+						}
+					}
+				});
+
+			Actions.Identify(Analytics.Client, traits, options);
+			FlushAndCheck(1);
+		}
+
 		[Test()]
 		public void TrackTest()
 		{
diff --git a/Test/Actions.cs b/Test/Actions.cs
@@ -49,6 +49,12 @@ public static void Identify(Client client)
 			Analytics.Client.Flush();
 		}
 
+		public static void Identify(Client client, Traits traits, Options options)
+		{
+			client.Identify("user", traits, options);
+			Analytics.Client.Flush();
+		}
+
 		public static void Group(Client client)
 		{
 			client.Group("user", "group", Traits(), Options());

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,12 @@ public static void Identify(Client client)`
`49`	`49`	`Analytics.Client.Flush();`
`50`	`50`	`}`
`51`	`51`
	`52`	`+ public static void Identify(Client client, Traits traits, Options options)`
	`53`	`+ {`
	`54`	`+ client.Identify("user", traits, options);`
	`55`	`+ Analytics.Client.Flush();`
	`56`	`+ }`
	`57`	`+`
`52`	`58`	`public static void Group(Client client)`
`53`	`59`	`{`
`54`	`60`	`client.Group("user", "group", Traits(), Options());`