This repository was archived by the owner on Jul 3, 2023. It is now read-only.
S3 logs expiration #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2016 14:16
Contributor
|
I'm concerned about this change since the previous value was to not expire the logs at all, this would implicitly change everyone's logs expiration. Could we keep the default behavior unchanged while still allowing the value to be configured (from reading the TF docs it's not straightforward how to achieve that). |
Contributor
Author
|
Hello @achille-roussel, The default behavior is kept. I added 2 vars :
So by default there is no logs expiration ;) |
Contributor
|
Alright, sounds good to me! Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to define a rule to expire logs after X days