Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(belongs-to): create now returns target model#9980

Merged
sushantdhiman merged 1 commit intosequelize:masterfrom
Munter:fix-8716
Oct 2, 2018
Merged

fix(belongs-to): create now returns target model#9980
sushantdhiman merged 1 commit intosequelize:masterfrom
Munter:fix-8716

Conversation

@Munter
Copy link
Contributor

@Munter Munter commented Oct 2, 2018 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #8716

@codecov
Copy link

codecov bot commented Oct 2, 2018 •
edited
Loading

Codecov Report

Merging #9980 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9980      +/-   ##
==========================================
+ Coverage   96.38%   96.38%   +<.01%     
==========================================
  Files          63       63              
  Lines        9388     9389       +1     
==========================================
+ Hits         9049     9050       +1     
  Misses        339      339
Impacted Files Coverage Δ
lib/associations/has-one.js 97.11% <ø> (ø) ⬆️
lib/associations/belongs-to.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053145c...0aaf09a. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 07fe591 into sequelize:master Oct 2, 2018
@sushantdhiman
Copy link
Contributor

sushantdhiman commented Oct 2, 2018

Thanks @Munter

@Munter Munter deleted the fix-8716 branch October 2, 2018 11:05
@sushantdhiman sushantdhiman mentioned this pull request Feb 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sushantdhiman sushantdhiman sushantdhiman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent create behavior when starting from hasMany vs belongsTo

2 participants

@Munter @sushantdhiman