Merge pull request #62 from bender2k14/optimize_critical_section

nblumhardt · web-flow · commit b146f27a0285 · 2019-06-24T16:10:47.000+10:00
Moved code out of critical section that isn't critical
diff --git a/src/Serilog.Sinks.Console/Sinks/SystemConsole/ConsoleSink.cs b/src/Serilog.Sinks.Console/Sinks/SystemConsole/ConsoleSink.cs
@@ -58,9 +58,10 @@ public void Emit(LogEvent logEvent)
             {
                 var buffer = new StringWriter(new StringBuilder(DefaultWriteBufferCapacity));
                 _formatter.Format(logEvent, buffer);
+                var formattedLogEventText = buffer.ToString();
                 lock (_syncRoot)
                 {
-                    output.Write(buffer.ToString());
+                    output.Write(formattedLogEventText);
                     output.Flush();
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,10 @@ public void Emit(LogEvent logEvent)`
`58`	`58`	`{`
`59`	`59`	`var buffer = new StringWriter(new StringBuilder(DefaultWriteBufferCapacity));`
`60`	`60`	`_formatter.Format(logEvent, buffer);`
	`61`	`+ var formattedLogEventText = buffer.ToString();`
`61`	`62`	`lock (_syncRoot)`
`62`	`63`	`{`
`63`		`- output.Write(buffer.ToString());`
	`64`	`+ output.Write(formattedLogEventText);`
`64`	`65`	`output.Flush();`
`65`	`66`	`}`
`66`	`67`	`}`