Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow borrowed deserialization #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfackler opened this issue Aug 2, 2017 · 0 comments
Closed

Allow borrowed deserialization #281

sfackler opened this issue Aug 2, 2017 · 0 comments

Comments

@sfackler
Copy link
Owner

sfackler commented Aug 2, 2017

If we changed FromSql to look like

pub trait FromSql<'a> {
    fn from_sql(ty: &Type, buf: &'a [u8]) -> Result<Self>;
}

This would allow implementations for &str and &[u8] which would be pretty handy. It's unfortunately a breaking change so it'll have to wait

cc @jwilm
sfackler added a commit that referenced this issue Apr 22, 2018
@sfackler
Allow FromSql to borrow from the buffer
9ad31d4 
This allows for in-place deserialization of text and bytea values in
particular.

Row::get_bytes is removed since it previously existed for this use case.

Closes #281
@sfackler sfackler mentioned this issue Apr 22, 2018
Merged
sfackler added a commit that referenced this issue Apr 22, 2018
@sfackler
Allow FromSql to borrow from the buffer
77cf4f3 
This allows for in-place deserialization of text and bytea values in
particular.

Row::get_bytes is removed since it previously existed for this use case.

Closes #281
sfackler added a commit that referenced this issue Apr 22, 2018
@sfackler
Allow FromSql to borrow from the buffer
d21f17c 
This allows for in-place deserialization of text and bytea values in
particular.

Row::get_bytes is removed since it previously existed for this use case.

Closes #281
sfackler added a commit that referenced this issue Apr 22, 2018
@sfackler
Allow FromSql to borrow from the buffer
95d4cf4 
This allows for in-place deserialization of text and bytea values in
particular.

Row::get_bytes is removed since it previously existed for this use case.

Closes #281
sfackler added a commit that referenced this issue Apr 22, 2018
@sfackler
Allow FromSql to borrow from the buffer
fcbed91 
This allows for in-place deserialization of text and bytea values in
particular.

Row::get_bytes is removed since it previously existed for this use case.

Closes #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfackler