Make executable mode change message more user-friendly

kuychaco · kuychaco · commit 2a153de89fe3 · 2018-01-17T15:16:26.000-08:00
diff --git a/lib/views/file-patch-view.js b/lib/views/file-patch-view.js
@@ -12,6 +12,11 @@ import Commands, {Command} from './commands';
 import FilePatchSelection from './file-patch-selection';
 import Switchboard from '../switchboard';
 
+const executableText = {
+  100644: 'non executable <code>100644</code>',
+  100755: 'executable <code>100755</code>',
+};
+
 export default class FilePatchView extends React.Component {
   static propTypes = {
     commandRegistry: PropTypes.object.isRequired,
@@ -297,12 +302,12 @@ export default class FilePatchView extends React.Component {
           </header>
           <div className="github-FilePatchView-metaDetails">
             File changed mode
-            <span className="github-FilePatchView-metaDiff github-FilePatchView-metaDiff--removed">
-              from <code>{executableModeChange.oldMode}</code>
-            </span>
-            <span className="github-FilePatchView-metaDiff github-FilePatchView-metaDiff--added">
-              to <code>{executableModeChange.newMode}</code>
-            </span>
+            <span className="github-FilePatchView-metaDiff github-FilePatchView-metaDiff--removed"
+              dangerouslySetInnerHTML={{__html: 'from ' + executableText[executableModeChange.oldMode]}}
+            />
+            <span className="github-FilePatchView-metaDiff github-FilePatchView-metaDiff--added"
+              dangerouslySetInnerHTML={{__html: 'to ' + executableText[executableModeChange.newMode]}}
+            />
           </div>
         </div>
       </div>
