Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ebcb06a

Browse files
smashwilsonsmashwilson
committed
Rename "visible" to "active" to be a bit more specific
1 parent a8c5f70 commit ebcb06a

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

‎test/controllers/root-controller.test.js

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -380,13 +380,13 @@ import RootController from '../../lib/controllers/root-controller';
380380

381381
const FAKE_PANE_ITEM = Symbol('fake pane item');
382382
mockDockItem = {
383-
visible: false,
383+
active: false,
384384
reveal() {
385-
this.visible = true;
385+
this.active = true;
386386
return Promise.resolve();
387387
},
388388
hide() {
389-
this.visible = false;
389+
this.active = false;
390390
return Promise.resolve();
391391
},
392392
getDockItem() {
@@ -399,114 +399,114 @@ import RootController from '../../lib/controllers/root-controller';
399399

400400
sinon.stub(workspace.getRightDock(), 'isVisible').returns(true);
401401
sinon.stub(workspace.getRightDock(), 'getPanes').callsFake(() => [{
402-
getActiveItem() { return mockDockItem.visible ? FAKE_PANE_ITEM : null; },
402+
getActiveItem() { return mockDockItem.active ? FAKE_PANE_ITEM : null; },
403403
}]);
404404
}
405405
});
406406

407-
function assertTabState({rendered, visible}) {
407+
function assertTabState({rendered, active}) {
408408
if (useDocks()) {
409409
const isRendered = wrapper.find('DockItem').find({stubItemSelector: `${tabName}-tab-controller`}).exists();
410-
const isVisible = mockDockItem.visible;
410+
const isActive = mockDockItem.active;
411411

412412
assert.equal(isRendered, rendered);
413-
assert.equal(isVisible, visible);
413+
assert.equal(isActive, active);
414414
} else {
415415
// Legacy panels API.
416416
// Legacy panels are always rendered, so disregard "rendered" assertions.
417417
const title = {git: 'Git', github: 'GitHub (preview)'}[tabName];
418418

419-
const isVisible = wrapper.find('Panel').find({visible: true})
419+
const isActive = wrapper.find('Panel').find({visible: true})
420420
.find('Tabs').find({activeIndex: tabIndex})
421421
.find('TabPanel').find({title})
422422
.exists();
423423

424-
assert.equal(isVisible, visible);
424+
assert.equal(isActive, active);
425425
}
426426
}
427427

428428
describe('toggle()', function() {
429429
it(`renders and reveals the ${tabName} tab when item is not rendered`, async function() {
430-
assertTabState({rendered: false, visible: false});
430+
assertTabState({rendered: false, active: false});
431431

432432
await tabTracker.toggle();
433433

434-
assertTabState({rendered: true, visible: true});
434+
assertTabState({rendered: true, active: true});
435435
});
436436

437437
if (!useLegacyPanels) {
438-
it(`reveals the ${tabName} tab when the item is rendered but not visible`, async function() {
438+
it(`reveals the ${tabName} tab when the item is rendered but not active`, async function() {
439439
wrapper.setState({[stateKey]: true});
440440

441-
assertTabState({rendered: true, visible: false});
441+
assertTabState({rendered: true, active: false});
442442

443443
await tabTracker.toggle();
444444

445-
assertTabState({rendered: true, visible: true});
445+
assertTabState({rendered: true, active: true});
446446
});
447447
}
448448

449449
it(`hides the ${tabName} tab when open`, async function() {
450450
wrapper.setState({[stateKey]: true, activeTab: tabIndex});
451-
mockDockItem.visible = true;
451+
mockDockItem.active = true;
452452

453-
assertTabState({rendered: true, visible: true});
453+
assertTabState({rendered: true, active: true});
454454

455455
await tabTracker.toggle();
456456

457-
assertTabState({rendered: true, visible: false});
457+
assertTabState({rendered: true, active: false});
458458
});
459459
});
460460

461461
describe('toggleFocus()', function() {
462462
it(`opens and focuses the ${tabName} tab when it is initially closed`, async function() {
463-
assertTabState({rendered: false, visible: false});
463+
assertTabState({rendered: false, active: false});
464464
sinon.stub(tabTracker, 'hasFocus').returns(false);
465465

466466
await tabTracker.toggleFocus();
467467

468-
assertTabState({rendered: true, visible: true});
468+
assertTabState({rendered: true, active: true});
469469
assert.isTrue(tabTracker.focus.called);
470470
assert.isFalse(workspace.getActivePane().activate.called);
471471
});
472472

473473
it(`focuses the ${tabName} tab when it is already open, but blurred`, async function() {
474474
await tabTracker.ensureVisible();
475-
assertTabState({rendered: true, visible: true});
475+
assertTabState({rendered: true, active: true});
476476
sinon.stub(tabTracker, 'hasFocus').returns(false);
477477

478478
await tabTracker.toggleFocus();
479479

480-
assertTabState({rendered: true, visible: true});
480+
assertTabState({rendered: true, active: true});
481481
assert.isTrue(tabTracker.focus.called);
482482
assert.isFalse(workspace.getActivePane().activate.called);
483483
});
484484

485485
it(`blurs the ${tabName} tab when it is already open and focused`, async function() {
486486
await tabTracker.ensureVisible();
487-
assertTabState({rendered: true, visible: true});
487+
assertTabState({rendered: true, active: true});
488488
sinon.stub(tabTracker, 'hasFocus').returns(true);
489489

490490
await tabTracker.toggleFocus();
491491

492-
assertTabState({rendered: true, visible: true});
492+
assertTabState({rendered: true, active: true});
493493
assert.isFalse(tabTracker.focus.called);
494494
assert.isTrue(workspace.getActivePane().activate.called);
495495
});
496496
});
497497

498498
describe('ensureVisible()', function() {
499499
it(`opens the ${tabName} tab when it is initially closed`, async function() {
500-
assertTabState({rendered: false, visible: false});
500+
assertTabState({rendered: false, active: false});
501501
assert.isTrue(await tabTracker.ensureVisible());
502-
assertTabState({rendered: true, visible: true});
502+
assertTabState({rendered: true, active: true});
503503
});
504504

505505
it(`does nothing when the ${tabName} tab is already open`, async function() {
506506
await tabTracker.toggle();
507-
assertTabState({rendered: true, visible: true});
507+
assertTabState({rendered: true, active: true});
508508
assert.isFalse(await tabTracker.ensureVisible());
509-
assertTabState({rendered: true, visible: true});
509+
assertTabState({rendered: true, active: true});
510510
});
511511
});
512512
});

0 commit comments

Comments
 (0)