Add CoopVec load/store pointer overloads #6822
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Apr 15, 2025
| int32_t* ptr; | ||
| } | ||
|
|
||
| //TEST_INPUT:ubuffer(data=[1 2 3 4 5 6 7 8], stride=4),name=buf |
There was a problem hiding this comment.
ptr isn't initialized with anything that is actually valid to read/write to.
TEST_INPUT allows you to assign a ubuffer to a pointer value, can you try that instead and turn this into an executable test?
There was a problem hiding this comment.
e.g.
//TEST_INPUT: set pObj = ubuffer(data=[2 0 0 0], stride=4);
uniform Obj* pObj;
There was a problem hiding this comment.
Thanks - is it possible to have these as output?
There was a problem hiding this comment.
Should be? I haven’t tried that yet…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.