-
Notifications
You must be signed in to change notification settings - Fork 283
Remove support for "module libraries" #6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove support for "module libraries" #6837
Conversation
This change *also* removes support for the `-r` command-line option to `slangc`, and the ability to pass `.slang-module` files as command-line arguments. It may turn out that some (or all) of the functionality being removed in this change is required by at least some existing users of the slang API or command-line compiler. The intention of this change is to provide a way to evaluate whether these changes would break any user code that is being tested by various automated CI processes.
/format |
🌈 Formatted, please merge the changes from this PR |
…-support Format code for PR shader-slang#6837
I'm using Particularly, CMake toolchains need a way for the compiler to generate object files from sources ( I think I could live with |
@juliusikkala Thanks for the feedback! This PR is definitely just an attempt on my part to find the boundaries between what is and isn't being used when it comes to this functinality, so knowing that passing a Also, FWIW, I strongly agree that the behavior you describe is desirable, for the reasons you went into. It's not that I don't think I'm going to keep iterating on this work, but for now your comment plus the various test failures (including some user code integration tests I've run internally) tell me that I can't just do the easy thing and eliminate this functionality entirely. |
This change also removes support for the
-r
command-line option toslangc
, and the ability to pass.slang-module
files as command-line arguments.It may turn out that some (or all) of the functionality being removed in this change is required by at least some existing users of the slang API or command-line compiler. The intention of this change is to provide a way to evaluate whether these changes would break any user code that is being tested by various automated CI processes.