Simplified replace logic in Java and Clojure Snippet. Added attributions.

aslakhellesoy · aslakhellesoy · commit ab1f39f7e258 · 2012-10-08T23:48:50.000+01:00
diff --git a/History.md b/History.md
@@ -1,5 +1,7 @@
 ## [Git master](https://github.com/cucumber/cucumber-jvm/compare/v1.0.14...master)
 
+* [Core] Added video/ogg mimetype to embedd videos in the HTMLReport ([#390](https://github.com/cucumber/cucumber-jvm/pull/390) Klaus Bayrhammer)
+* [Groovy] Generated Groovy step definitions need backslashes to be escaped ([#391](https://github.com/cucumber/cucumber-jvm/issues/391), [#400](https://github.com/cucumber/cucumber-jvm/pull/400), Martin Hauner)
 * [Java] The java module (and all other modules) finally compile on JDK 7 and OS X. (David Kowis, Sébastien Le Callonnec, Aslak Hellesøy)
 * [Core] The `cucumber.options` System property will no longer completely override all arguments set in `@Cucumber.Options` or
   on the command line. Instead, it will keep those and only override those that are specified in `cucumber.options`.
diff --git a/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippet.java b/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippet.java
@@ -40,6 +40,6 @@ public String namedGroupEnd() {
 
     @Override
     public String escapePattern(String pattern) {
-        return pattern.replaceAll("\"", "\\\\\"");
+        return pattern.replace("\"", "\\\"");
     }
 }
diff --git a/java/src/main/java/cucumber/runtime/java/JavaSnippet.java b/java/src/main/java/cucumber/runtime/java/JavaSnippet.java
@@ -45,6 +45,6 @@ public String namedGroupEnd() {
 
     @Override
     public String escapePattern(String pattern) {
-        return pattern.replaceAll("\\\\", "\\\\\\\\").replaceAll("\"", "\\\\\"");
+        return pattern.replace("\\", "\\\\").replace("\"", "\\\"");
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,6 @@ public String namedGroupEnd() {`
`40`	`40`
`41`	`41`	`@Override`
`42`	`42`	`public String escapePattern(String pattern) {`
`43`		`- return pattern.replaceAll("\"", "\\\\\"");`
	`43`	`+ return pattern.replace("\"", "\\\"");`
`44`	`44`	`}`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,6 @@ public String namedGroupEnd() {`
`45`	`45`
`46`	`46`	`@Override`
`47`	`47`	`public String escapePattern(String pattern) {`
`48`		`- return pattern.replaceAll("\\\\", "\\\\\\\\").replaceAll("\"", "\\\\\"");`
	`48`	`+ return pattern.replace("\\", "\\\\").replace("\"", "\\\"");`
`49`	`49`	`}`
`50`	`50`	`}`