Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sgillies
Copy link
Contributor

@sgillies sgillies commented Sep 17, 2024

Conditions in a test signal to me that we should consider splitting up the test. We have more tests, but they are simpler, and won't have any bugs of their own.

@sgillies sgillies self-assigned this Sep 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10910242816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.555%

Totals Coverage Status
Change from base Build 10899958577: 0.0%
Covered Lines: 2603
Relevant Lines: 2973

💛 - Coveralls

@sgillies sgillies added this to the 2.1 milestone Sep 18, 2024
@theroggy
Copy link
Member

theroggy commented Sep 18, 2024

Just to clarify why the test was written as it is/was. I won't loose any sleep on this being changed ;-).

Even though I agree in general, I wrote this test as it is/was to have a clear overview in the parameters how each input WKT is treated depending on the different possible values of on_invalid.
When there is a new relevant case to be added to the test in the future it is also very clear and easy to add this for the different cases, without risk that one of the possibilities gets forgotten.

With the test split up you need to scroll through the different tests and it is quite a bit more difficult to get this overview.

@sgillies sgillies marked this pull request as draft September 18, 2024 18:50
@sgillies
Copy link
Contributor Author

@theroggy I agree, I did lose the synoptic overview, that's fair. I'll improve this. I bet we can have it all.

@sgillies sgillies removed this from the 2.1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants