refactor: use es6 class syntax for CommandError

nfischer · nfischer · commit 168e8b5a0848 · 2025-04-10T00:56:02.000-07:00
This is supposed to be a NOOP, although for some reason this makes a
difference in the ava@6 test framework. This should not have a
user-visible effect because CommandError is an implementation detail of
this library (it's only thrown if `options.fatal` is off, and it's
always caught inside of common.js).
diff --git a/src/common.js b/src/common.js
@@ -83,11 +83,12 @@ exports.convertErrorOutput = convertErrorOutput;
 
 // An exception class to help propagate command errors (e.g., non-zero exit
 // status) up to the top-level. {@param value} should be a ShellString.
-function CommandError(value) {
-  this.returnValue = value;
+class CommandError extends Error {
+  constructor(value) {
+    super(value.toString());
+    this.returnValue = value;
+  }
 }
-CommandError.prototype = Object.create(Error.prototype);
-CommandError.prototype.constructor = CommandError;
 exports.CommandError = CommandError; // visible for testing
 
 // Shows error message. Throws if fatal is true (defaults to config.fatal, overridable with options.fatal)
