chore(node): add v10 and v11 to CI (#921)

nfischer · web-flow · commit 355287e2ff8d · 2018-12-03T00:20:38.000-08:00
This adds support for v10 and v11, and removes a TODO.
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,8 @@ node_js:
   - 7
   - 8
   - 9
+  - 10
+  - 11
 
 os:
   - linux
diff --git a/appveyor.yml b/appveyor.yml
@@ -1,5 +1,7 @@
 environment:
   matrix:
+    - nodejs_version: '11'
+    - nodejs_version: '10'
     - nodejs_version: '9'
     - nodejs_version: '8'
     - nodejs_version: '7'
diff --git a/scripts/check-node-support.js b/scripts/check-node-support.js
@@ -9,7 +9,7 @@ var shell = require('..');
 
 // This is the authoritative list of supported node versions.
 var MIN_NODE_VERSION = 6;
-var MAX_NODE_VERSION = 9;
+var MAX_NODE_VERSION = 11;
 
 function checkReadme(minNodeVersion) {
   var start = '<!-- start minVersion -->';
diff --git a/src/exec-child.js b/src/exec-child.js
@@ -28,8 +28,6 @@ function isMaxBufferError(err) {
     // >= v10
     // RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length
     // exceeded
-    // TODO(nfischer): remove when we add v10 CI (Github issue #856).
-    /* istanbul ignore next */
     return true;
   }
   return false;

-Original file line number
+Diff line change
   - 7
   - 8
   - 9
 +  - 10
 +  - 11
 os:
   - linux
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ function isMaxBufferError(err) {`
`28`	`28`	`// >= v10`
`29`	`29`	`// RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length`
`30`	`30`	`// exceeded`
`31`		`- // TODO(nfischer): remove when we add v10 CI (Github issue #856).`
`32`		`- /* istanbul ignore next */`
`33`	`31`	`return true;`
`34`	`32`	`}`
`35`	`33`	`return false;`