Merge pull request plotly#139 from plotly/jshint-jasmine

etpinard · etpinard · commit ebdb86e88f10 · 2015-12-22T10:30:10.000-05:00
Add syntax test for jasmine test files
diff --git a/circle.yml b/circle.yml
@@ -21,3 +21,4 @@ test:
   override:
     - sudo lxc-attach -n "$(docker inspect --format '{{.Id}}' mytestbed)" -- bash -c "cd /var/www/streambed/image_server/plotly.js && node test/image/compare_pixels_test.js"
     - npm run citest-jasmine
+    - npm run test-syntax
diff --git a/package.json b/package.json
@@ -32,6 +32,7 @@
     "test-jasmine": "karma start test/jasmine/karma.conf.js",
     "citest-jasmine": "karma start test/jasmine/karma.ciconf.js",
     "test-image": "./tasks/test_image.sh",
+    "test-syntax": "node test/syntax_test.js",
     "test": "npm run test-jasmine && npm test-image",
     "start-test_dashboard": "node devtools/test_dashboard/server.js",
     "start-image_viewer": "node devtools/image_viewer/server.js",
@@ -83,6 +84,7 @@
     "browserify": "^12.0.1",
     "browserify-transform-tools": "^1.5.0",
     "ecstatic": "^1.2.0",
+    "glob": "^6.0.1",
     "jasmine-core": "^2.3.4",
     "jshint": "^2.8.0",
     "karma": "^0.13.15",
diff --git a/tasks/util/constants.js b/tasks/util/constants.js
@@ -42,6 +42,8 @@ module.exports = {
     pathToTestImagesDiff: path.join(pathToBuild, 'test_images_diff/'),
     pathToTestImagesDiffList: path.join(pathToBuild, 'list_of_incorrect_images.txt'),
 
+    pathToJasmineTests: path.join(pathToRoot, 'test/jasmine/tests'),
+
     uglifyOptions: {
         fromString: true,
         mangle: true,
diff --git a/test/syntax_test.js b/test/syntax_test.js
@@ -0,0 +1,33 @@
+var path = require('path');
+var fs = require('fs');
+
+var jshint = require('jshint').JSHINT;
+var glob = require('glob');
+
+var constants = require('../tasks/util/constants');
+
+var focusGlobals = ['fdescribe', 'fit'];
+var logs = [];
+
+
+glob(path.join(constants.pathToJasmineTests, '**/*.js'), function(err, files) {
+    files.forEach(function(file) {
+        var code = fs.readFileSync(file, 'utf-8');
+
+        jshint(code);
+
+        var impliedGlobals = jshint.data().implieds;
+
+        impliedGlobals.forEach(function(obj) {
+            if(focusGlobals.indexOf(obj.name) !== -1) {
+                logs.push([
+                    path.basename(file),
+                    '[line ' + obj.line + '] :',
+                    'contains either a *fdescribe* or a *fit* block.'
+                ].join(' '));
+            }
+        });
+    });
+
+    if(logs.length) throw new Error(logs.join('\n'));
+});
