improve performance of snake case.

taylorotwell · taylorotwell · commit 9f162064acd4 · 2013-02-13T16:58:08.000-06:00
diff --git a/src/Illuminate/Support/Str.php b/src/Illuminate/Support/Str.php
@@ -196,11 +196,9 @@ public static function slug($title, $separator = '-')
 	 */
 	public static function snake($value, $delimiter = '_')
 	{
-		return trim(preg_replace_callback('/[A-Z]/', function($match) use ($delimiter)
-		{
-			return $delimiter.strtolower($match[0]);
+		$replace = '$1'.$delimiter.'$2';
 
-		}, $value), $delimiter);
+		return ctype_lower($value) ? $value : strtolower(preg_replace('/(.)([A-Z])/', $replace, $value));
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -196,11 +196,9 @@ public static function slug($title, $separator = '-')`
`196`	`196`	`*/`
`197`	`197`	`public static function snake($value, $delimiter = '_')`
`198`	`198`	`{`
`199`		`- return trim(preg_replace_callback('/[A-Z]/', function($match) use ($delimiter)`
`200`		`- {`
`201`		`- return $delimiter.strtolower($match[0]);`
	`199`	`+ $replace = '$1'.$delimiter.'$2';`
`202`	`200`
`203`		`- }, $value), $delimiter);`
	`201`	`+ return ctype_lower($value) ? $value : strtolower(preg_replace('/(.)([A-Z])/', $replace, $value));`
`204`	`202`	`}`
`205`	`203`
`206`	`204`	`/**`