do not slice array just to read its values in sort loop

etpinard · etpinard · commit 9c70ee963d5a · 2017-05-09T15:12:57.000-04:00
diff --git a/src/transforms/sort.js b/src/transforms/sort.js
@@ -78,18 +78,17 @@ exports.calcTransform = function(gd, trace, opts) {
 
     var target = opts.target;
     var len = targetArray.length;
-
     var arrayAttrs = PlotSchema.findArrayAttributes(trace);
     var d2c = Axes.getDataToCoordFunc(gd, trace, target, targetArray);
     var indices = getIndices(opts, targetArray, d2c);
 
     for(var i = 0; i < arrayAttrs.length; i++) {
         var np = Lib.nestedProperty(trace, arrayAttrs[i]);
-        var arrayCopy = np.get().slice();
+        var arrayOld = np.get();
         var arrayNew = new Array(len);
 
         for(var j = 0; j < len; j++) {
-            arrayNew[j] = arrayCopy[indices[j]];
+            arrayNew[j] = arrayOld[indices[j]];
         }
 
         np.set(arrayNew);
