Thanks clippy

EliahKagan · EliahKagan · commit 344f25047162 · 2025-08-01T06:33:24.000-04:00
This applies some changes recommended by clippy that have caused the clippy check to start failingo on CI as in: https://github.com/EliahKagan/cargo-smart-release/actions/runs/16672703924/job/47192391862 This was done by running `cargo clippy --fix` followed by `cargo fmt` and inspecting the result.
diff --git a/src/changelog/parse.rs b/src/changelog/parse.rs
@@ -427,7 +427,7 @@ fn record_unknown_range(out: &mut Vec<section::Segment>, range: Option<Range<usi
 }
 
 fn track_unknown_event(unknown_event: Event<'_>, unknown: &mut String) {
-    log::trace!("Cannot handle {:?}", unknown_event);
+    log::trace!("Cannot handle {unknown_event:?}");
     match unknown_event {
         Event::Html(text)
         | Event::Code(text)
diff --git a/src/command/changelog.rs b/src/command/changelog.rs
@@ -129,7 +129,7 @@ pub fn changelog(opts: Options, crates: Vec<String>) -> anyhow::Result<()> {
         change.commit()?;
     }
     if num_changes != 0 {
-        log::info!("Wrote {} changelogs", num_changes);
+        log::info!("Wrote {num_changes} changelogs");
     }
 
     Ok(())
diff --git a/src/command/release/cargo.rs b/src/command/release/cargo.rs
@@ -56,9 +56,7 @@ pub(in crate::command::release_impl) fn publish_crate(
             bail!("Could not successfully execute 'cargo publish'.")
         } else {
             log::warn!(
-                "'cargo publish' run {} failed but we retry up to {} times to rule out flakiness",
-                attempt,
-                max_attempts
+                "'cargo publish' run {attempt} failed but we retry up to {max_attempts} times to rule out flakiness"
             );
         }
     }
diff --git a/src/command/release/git.rs b/src/command/release/git.rs
@@ -56,7 +56,7 @@ pub(in crate::command::release_impl) fn create_version_tag<'repo>(
                 );
             }
             None => {
-                log::trace!("WOULD create tag {}", tag_name);
+                log::trace!("WOULD create tag {tag_name}");
             }
         }
         Ok(Some(format!("refs/tags/{tag_name}").try_into()?))
diff --git a/src/command/release/github.rs b/src/command/release/github.rs
@@ -64,8 +64,7 @@ pub fn create_release(
     cmd.arg(notes);
     if !dry_run && !cmd.status()?.success() {
         log::warn!(
-            "'gh' tool execution failed - considering this non-critical, and you may try to create the release with: {:?}",
-            cmd
+            "'gh' tool execution failed - considering this non-critical, and you may try to create the release with: {cmd:?}"
         );
     }
     Ok(())
diff --git a/src/command/release/manifest.rs b/src/command/release/manifest.rs
@@ -246,7 +246,7 @@ fn commit_locks_and_generate_bail_message(
             );
             if !allow_fully_generated_changelogs {
                 for crate_name in crate_names {
-                    log::warn!("{} {}", fix_preamble, crate_name);
+                    log::warn!("{fix_preamble} {crate_name}");
                 }
             }
         }
diff --git a/src/command/release/mod.rs b/src/command/release/mod.rs
@@ -358,9 +358,11 @@ fn present_and_validate_dependencies(
             .map(|d| d.package.name.as_str())
             .collect::<Vec<_>>();
         if !crate_names_for_manifest_updates.is_empty() {
-            let plural_s = (crate_names_for_manifest_updates.len() > 1)
-                .then_some("s")
-                .unwrap_or_default();
+            let plural_s = if crate_names_for_manifest_updates.len() > 1 {
+                "s"
+            } else {
+                Default::default()
+            };
             log::info!(
                 "{} adjust version constraints in manifest{} of {} package{} as direct dependencies are changing: {}",
                 will(dry_run),
@@ -502,7 +504,7 @@ fn wait_for_release(
         }
 
         std::thread::sleep(sleep_time);
-        log::info!("attempt {}", attempt);
+        log::info!("attempt {attempt}");
     }
     Ok(())
 }
diff --git a/src/context.rs b/src/context.rs
@@ -84,10 +84,7 @@ fn fill_in_root_crate_if_needed(crate_names: Vec<String>) -> anyhow::Result<Vec<
         } else {
             dir_name.to_owned()
         };
-        log::warn!(
-            "Using '{}' as crate name as no one was provided. Specify one if this isn't correct",
-            crate_name
-        );
+        log::warn!("Using '{crate_name}' as crate name as no one was provided. Specify one if this isn't correct");
         vec![crate_name]
     } else {
         crate_names
diff --git a/src/git/mod.rs b/src/git/mod.rs
@@ -49,7 +49,7 @@ pub fn change_since_last_release(package: &Package, ctx: &crate::Context) -> any
                         .peel_to_kind(object::Kind::Tree)?
                         .into_tree()
                         .peel_to_entry(components.clone())?
-                        .unwrap_or_else(|| panic!("path '{}' must exist in current_commit `{}`", dir, current_commit))
+                        .unwrap_or_else(|| panic!("path '{dir}' must exist in current_commit `{current_commit}`"))
                         .object_id();
                     if let Some(released_dir_entry) = released_target
                         .object()?

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ fn record_unknown_range(out: &mut Vec<section::Segment>, range: Option<Range<usi`
`427`	`427`	`}`
`428`	`428`
`429`	`429`	`fn track_unknown_event(unknown_event: Event<'_>, unknown: &mut String) {`
`430`		`- log::trace!("Cannot handle {:?}", unknown_event);`
	`430`	`+ log::trace!("Cannot handle {unknown_event:?}");`
`431`	`431`	`match unknown_event {`
`432`	`432`	`Event::Html(text)`
`433`	`433`	`\| Event::Code(text)`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ pub fn changelog(opts: Options, crates: Vec<String>) -> anyhow::Result<()> {`
`129`	`129`	`change.commit()?;`
`130`	`130`	`}`
`131`	`131`	`if num_changes != 0 {`
`132`		`- log::info!("Wrote {} changelogs", num_changes);`
	`132`	`+ log::info!("Wrote {num_changes} changelogs");`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`Ok(())`
Original file line number	Diff line number	Diff line change
`@@ -56,9 +56,7 @@ pub(in crate::command::release_impl) fn publish_crate(`
`56`	`56`	`bail!("Could not successfully execute 'cargo publish'.")`
`57`	`57`	`} else {`
`58`	`58`	`log::warn!(`
`59`		`- "'cargo publish' run {} failed but we retry up to {} times to rule out flakiness",`
`60`		`- attempt,`
`61`		`- max_attempts`
	`59`	`+ "'cargo publish' run {attempt} failed but we retry up to {max_attempts} times to rule out flakiness"`
`62`	`60`	`);`
`63`	`61`	`}`
`64`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ pub(in crate::command::release_impl) fn create_version_tag<'repo>(`
`56`	`56`	`);`
`57`	`57`	`}`
`58`	`58`	`None => {`
`59`		`- log::trace!("WOULD create tag {}", tag_name);`
	`59`	`+ log::trace!("WOULD create tag {tag_name}");`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`Ok(Some(format!("refs/tags/{tag_name}").try_into()?))`
Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ fn commit_locks_and_generate_bail_message(`
`246`	`246`	`);`
`247`	`247`	`if !allow_fully_generated_changelogs {`
`248`	`248`	`for crate_name in crate_names {`
`249`		`- log::warn!("{} {}", fix_preamble, crate_name);`
	`249`	`+ log::warn!("{fix_preamble} {crate_name}");`
`250`	`250`	`}`
`251`	`251`	`}`
`252`	`252`	`}`