clang-tidy performance fix

daniele77 · daniele77 · commit 9a89fbd5d206 · 2021-03-29T17:51:01.000+02:00
diff --git a/examples/pluginmanager.cpp b/examples/pluginmanager.cpp
@@ -129,7 +129,7 @@ class Registration
 public:
     Registration(const string& name, Factory factory)
     {
-        PluginRegistry::Instance().Register(name, factory);
+        PluginRegistry::Instance().Register(name, std::move(factory));
     }
 };
 
diff --git a/include/cli/cli.h b/include/cli/cli.h
@@ -712,7 +712,7 @@ namespace cli
             bool found = globalScopeMenu->ScanCmds(strs, *this);
 
             // root menu recursive cmds check
-            if (!found) found = current->ScanCmds(std::move(strs), *this); // last use of strs
+            if (!found) found = current->ScanCmds(strs, *this);
 
             if (!found) // error msg if not found
                 out << "wrong command: " << cmd << '\n';
diff --git a/include/cli/detail/genericasioremotecli.h b/include/cli/detail/genericasioremotecli.h
@@ -444,7 +444,7 @@ class CliTelnetSession : public InputDevice, public TelnetSession, public CliSes
 {
 public:
 
-    CliTelnetSession(Scheduler& _scheduler, asiolib::ip::tcp::socket _socket, Cli& _cli, std::function< void(std::ostream&)> _exitAction, std::size_t historySize ) :
+    CliTelnetSession(Scheduler& _scheduler, asiolib::ip::tcp::socket _socket, Cli& _cli, const std::function< void(std::ostream&)>& _exitAction, std::size_t historySize ) :
         InputDevice(_scheduler),
         TelnetSession(std::move(_socket)),
         CliSession(_cli, TelnetSession::OutStream(), historySize),
diff --git a/test/test_cli.cpp b/test/test_cli.cpp
@@ -40,7 +40,7 @@ namespace {
 string ExtractFirstPrompt(const stringstream& o)
 {
     auto content = o.str();
-    std::size_t pos = content.find_first_of(">");
+    std::size_t pos = content.find_first_of('>');
     return content.substr(0, pos);
 }
 
@@ -49,7 +49,7 @@ string ExtractLastPrompt(const stringstream& o)
     auto content = o.str();
     std::size_t pos = content.find_last_of('\n');
     content = content.substr(pos+1);
-    pos = content.find_last_of(">");
+    pos = content.find_last_of('>');
     return content.substr(0, pos);
 }
 
@@ -69,7 +69,7 @@ string ExtractContent(const stringstream& o)
 {
     auto content = o.str();
     // last line
-    auto lastNL = content.find_last_of("\n");
+    auto lastNL = content.find_last_of('\n');
     auto lastLine = content.substr(lastNL+1);
     content = content.substr(0, lastNL);
     auto pos = content.find(lastLine);

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ class Registration`
`129`	`129`	`public:`
`130`	`130`	`Registration(const string& name, Factory factory)`
`131`	`131`	`{`
`132`		`- PluginRegistry::Instance().Register(name, factory);`
	`132`	`+ PluginRegistry::Instance().Register(name, std::move(factory));`
`133`	`133`	`}`
`134`	`134`	`};`
`135`	`135`
Original file line number	Diff line number	Diff line change
`@@ -444,7 +444,7 @@ class CliTelnetSession : public InputDevice, public TelnetSession, public CliSes`
`444`	`444`	`{`
`445`	`445`	`public:`
`446`	`446`
`447`		`- CliTelnetSession(Scheduler& _scheduler, asiolib::ip::tcp::socket _socket, Cli& _cli, std::function< void(std::ostream&)> _exitAction, std::size_t historySize ) :`
	`447`	`+ CliTelnetSession(Scheduler& _scheduler, asiolib::ip::tcp::socket _socket, Cli& _cli, const std::function< void(std::ostream&)>& _exitAction, std::size_t historySize ) :`
`448`	`448`	`InputDevice(_scheduler),`
`449`	`449`	`TelnetSession(std::move(_socket)),`
`450`	`450`	`CliSession(_cli, TelnetSession::OutStream(), historySize),`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ namespace {`
`40`	`40`	`string ExtractFirstPrompt(const stringstream& o)`
`41`	`41`	`{`
`42`	`42`	`auto content = o.str();`
`43`		`- std::size_t pos = content.find_first_of(">");`
	`43`	`+ std::size_t pos = content.find_first_of('>');`
`44`	`44`	`return content.substr(0, pos);`
`45`	`45`	`}`
`46`	`46`
`@@ -49,7 +49,7 @@ string ExtractLastPrompt(const stringstream& o)`
`49`	`49`	`auto content = o.str();`
`50`	`50`	`std::size_t pos = content.find_last_of('\n');`
`51`	`51`	`content = content.substr(pos+1);`
`52`		`- pos = content.find_last_of(">");`
	`52`	`+ pos = content.find_last_of('>');`
`53`	`53`	`return content.substr(0, pos);`
`54`	`54`	`}`
`55`	`55`
`@@ -69,7 +69,7 @@ string ExtractContent(const stringstream& o)`
`69`	`69`	`{`
`70`	`70`	`auto content = o.str();`
`71`	`71`	`// last line`
`72`		`- auto lastNL = content.find_last_of("\n");`
	`72`	`+ auto lastNL = content.find_last_of('\n');`
`73`	`73`	`auto lastLine = content.substr(lastNL+1);`
`74`	`74`	`content = content.substr(0, lastNL);`
`75`	`75`	`auto pos = content.find(lastLine);`