Optimized combiner logic

Dilip Krishnan · Dilip Krishnan · commit cd94dc63fed1 · 2017-04-21T06:48:45.000-05:00
We only need to combine grouped entries that have more than one request handler. related to springfox#1780
diff --git a/springfox-spring-web/src/main/java/springfox/documentation/spring/web/plugins/DefaultRequestHandlerCombiner.java b/springfox-spring-web/src/main/java/springfox/documentation/spring/web/plugins/DefaultRequestHandlerCombiner.java
@@ -63,8 +63,10 @@ private Collection<? extends RequestHandler> combined(Collection<RequestHandler>
       List<RequestHandler> handlers = groupByEquality.get(path);
 
       RequestHandler toCombine = path.get();
-      for (RequestHandler each : handlers) {
-        toCombine = combine(toCombine, each);
+      if (handlers.size() > 1) {
+        for (RequestHandler each : handlers) {
+          toCombine = combine(toCombine, each);
+        }
       }
       combined.add(toCombine);
     }

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,10 @@ private Collection<? extends RequestHandler> combined(Collection<RequestHandler>`
`63`	`63`	`List<RequestHandler> handlers = groupByEquality.get(path);`
`64`	`64`
`65`	`65`	`RequestHandler toCombine = path.get();`
`66`		`- for (RequestHandler each : handlers) {`
`67`		`- toCombine = combine(toCombine, each);`
	`66`	`+ if (handlers.size() > 1) {`
	`67`	`+ for (RequestHandler each : handlers) {`
	`68`	`+ toCombine = combine(toCombine, each);`
	`69`	`+ }`
`68`	`70`	`}`
`69`	`71`	`combined.add(toCombine);`
`70`	`72`	`}`