Fix extraction of files in some examples #1491
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix how the tar.gz archives that get downloaded are extracted in a few different examples. The previous code was getting the folder where files are extracted by splitting the full path of the downloaded .tar.gz archive using a `"."`. This causes issues when any parent folder contains a dot: the directory that is returned is not the correct one.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
- Coverage 86.18% 86.17% -0.01%
==========================================
Files 394 394
Lines 50299 50323 +24
Branches 5309 5313 +4
==========================================
+ Hits 43351 43367 +16
- Misses 5494 5498 +4
- Partials 1454 1458 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix how the tar.gz archives that get downloaded are extracted in a few different examples. The previous code was getting the folder where files are extracted by splitting the full path of the downloaded .tar.gz archive using a
".". This causes issues when any parent folder contains a dot: the directory that is returned is not the correct one.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
What does this implement/fix?
Additional information