dashboards now autosize based on GUI

Kully · Kully · commit b091aaf72b29 · 2018-03-02T00:34:37.000-08:00
diff --git a/plotly/dashboard_objs/dashboard_objs.py b/plotly/dashboard_objs/dashboard_objs.py
@@ -265,6 +265,21 @@ def _path_to_box(self, path):
             loc_in_dashboard = loc_in_dashboard[first_second]
         return loc_in_dashboard
 
+    def _set_dashboard_size(self):
+        # set dashboard size to keep consistent with GUI
+        num_of_boxes = len(self._compute_box_ids())
+        if num_of_boxes == 0:
+            pass
+        elif num_of_boxes == 1:
+            self['layout']['size'] = 800
+            self['layout']['sizeUnit'] = 'px'
+        elif num_of_boxes == 2:
+            self['layout']['size'] = 1500
+            self['layout']['sizeUnit'] = 'px'
+        else:
+            self['layout']['size'] = 1500 + 350 * (num_of_boxes - 2)
+            self['layout']['sizeUnit'] = 'px'
+
     def get_box(self, box_id):
         """Returns box from box_id number."""
         box_ids_to_path = self._compute_box_ids()
@@ -496,6 +511,8 @@ def insert(self, box, side='above', box_id=None, fill_percent=50):
                     "'above', 'below', 'left', and 'right'."
                 )
 
+        self._set_dashboard_size()
+
     def remove(self, box_id):
         """
         Remove a box from the dashboard by its box_id.
@@ -535,6 +552,8 @@ def remove(self, box_id):
         else:
             self['layout'] = None
 
+        self._set_dashboard_size()
+
     def swap(self, box_id_1, box_id_2):
         """
         Swap two boxes with their specified ids.
diff --git a/plotly/tests/test_core/test_dashboard/test_dashboard.py b/plotly/tests/test_core/test_dashboard/test_dashboard.py
@@ -111,7 +111,7 @@ def test_dashboard_dict(self):
         }
 
         dash = dashboard.Dashboard()
-        dash.insert(my_box, '', 0)
+        dash.insert(my_box)
         dash.insert(my_box, 'above', 1)
 
         expected_dashboard = {
@@ -131,12 +131,11 @@ def test_dashboard_dict(self):
                                  'sizeUnit': '%',
                                  'type': 'split'},
                        'second': {'boxType': 'empty', 'type': 'box'},
-                   'size': 500,
+                   'size': 1500,
                    'sizeUnit': 'px',
                    'type': 'split'},
             'settings': {},
             'version': 2
         }
 
-
         self.assertEqual(dash['layout'], expected_dashboard['layout'])
