Close issues in batches

sledgehammer999 · sledgehammer999 · commit e71193dea78f · 2020-10-29T23:37:05.000+02:00
It seems that GitHub's API has an undocumented limit on how many GraphQL aliases you can put in one mutation query.
Current limit is set to 10, since it seems logical.
diff --git a/MassCloseOldIssues/issueupdater.cpp b/MassCloseOldIssues/issueupdater.cpp
@@ -32,6 +32,11 @@ SOFTWARE. */
 
 using json = nlohmann::json;
 
+namespace
+{
+    constexpr int BATCH_SIZE = 10;
+}
+
 IssueUpdater::IssueUpdater(const ProgramOptions &programOptions, PostDownloader &downloader,
                            const std::vector<std::string> &issues,
                            std::string_view labelID, std::string &error)
@@ -40,12 +45,31 @@ IssueUpdater::IssueUpdater(const ProgramOptions &programOptions, PostDownloader
     , m_issues(issues)
     , m_labelID(labelID)
     , m_error(error)
+    , m_hasNextBatch(m_issues.size() > 0)
 {
     m_error.clear();
 }
 
 void IssueUpdater::run()
 {
+    if (!hasNextBatch())
+        return;
+
+    m_downloader.setFinishedHandler(beast::bind_front_handler(&IssueUpdater::onFinishedPage, this));
+
+    json req;
+    req["query"] = nextBatch();
+    m_downloader.setRequestBody(req.dump());
+
+    m_downloader.run();
+    m_downloader.setFinishedHandler(FinishedHandler{});
+}
+
+std::string IssueUpdater::nextBatch()
+{
+    if (!hasNextBatch())
+        return {};
+
     // Sample QraphQL string for the mutation with one alias named 'issue0'
     // "mutation UpdateIssue { comment0: : addComment(input: {subjectId:\"ID\", body:\"COMMENT\"}) { clientMutationId }
     //                         label0: addLabelsToLabelable(input: {labelableId:\"ID\", labelIds:[\"ID\"]}) { clientMutationId }
@@ -58,7 +82,9 @@ void IssueUpdater::run()
     int counter = 0;
     std::ostringstream buffer;
     buffer << start;
-    for (const auto &issueID : m_issues) {
+    for (; ((m_issuePos < m_issues.size()) && (counter < BATCH_SIZE)); ++m_issuePos) {
+        const auto &issueID = m_issues[m_issuePos];
+
         if (!m_programOptions.comment.empty())
             buffer << makeCommentAlias(counter, issueID);
 
@@ -72,16 +98,17 @@ void IssueUpdater::run()
 
         ++counter;
     }
-    buffer << end;
 
-    m_downloader.setFinishedHandler(beast::bind_front_handler(&IssueUpdater::onFinishedPage, this));
+    if (m_issuePos == m_issues.size())
+        m_hasNextBatch = false;
 
-    json req;
-    req["query"] = buffer.str();
-    m_downloader.setRequestBody(req.dump());
+    buffer << end;
+    return buffer.str();
+}
 
-    m_downloader.run();
-    m_downloader.setFinishedHandler(FinishedHandler{});
+bool IssueUpdater::hasNextBatch()
+{
+    return m_hasNextBatch;
 }
 
 void IssueUpdater::onFinishedPage()
@@ -97,6 +124,14 @@ void IssueUpdater::onFinishedPage()
     }
 
     checkResponse(m_downloader.response().body());
+
+    if (!m_error.empty() || !hasNextBatch())
+        return;
+
+    json req;
+    req["query"] = nextBatch();
+    m_downloader.setRequestBody(req.dump());
+    m_downloader.sendRequest();
 }
 
 void IssueUpdater::checkResponse(std::string_view response)
diff --git a/MassCloseOldIssues/issueupdater.h b/MassCloseOldIssues/issueupdater.h
@@ -37,6 +37,8 @@ class IssueUpdater
                           std::string_view labelID, std::string &error);
 
     void run();
+    std::string nextBatch();
+    bool hasNextBatch();
 
 private:
     void onFinishedPage();
@@ -53,4 +55,6 @@ class IssueUpdater
     const std::vector<std::string> &m_issues;
     const std::string m_labelID;
     std::string &m_error;
+    int m_issuePos = 0;
+    bool m_hasNextBatch;
 };
