feat: support relative import inside slides #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for working on it! You are amazing! |
antfu
approved these changes
Jul 17, 2024
Member
antfu
left a comment
There was a problem hiding this comment.
I am ok with the direction, I'll let you handle the merge and release
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1708. It will be much smaller after merging that one.
Previously, it wasn't possible to import assets via relative paths. For example,
. This was because the slides contents were loaded as/@slidev/slide/1.md.This PR loads the slides in
path/to/slides.mdaspath/to/slides.md__slidev_x.md, wherexis the slide no in the presentation, instead of the slide no in that Markdown file. And/@slidev/slide/x.mdworks as a facade which re-exportspath/to/slides.md__slidev_x.md. The same for frontmatter.The reason why not use urls like
path/to/slides.md?slidev=x.mdis that this will conflict with Vue's logic. The Vue plugin doesn't preserve the query of the URL. Also, Vue plugin'sincludeoption only matches the path part without query string.This PR also splits
vite/loaders.tsinto multiple files - each Vite plugin has its own file. And removed most of the usages ofenforce/order.