Stop passing getApplicationContext() in to the constructor. It's not necessary, and can be derived from the ReactApplicationContext object.

mikelambert · mikelambert · commit 1efb5baf7e53 · 2016-10-27T04:35:07.000-04:00
diff --git a/README.md b/README.md
@@ -144,7 +144,7 @@ public class MainApplication extends Application implements ReactApplication {
     protected List<ReactPackage> getPackages() {
       return Arrays.<ReactPackage>asList(
           new MainReactPackage(),
-            new FirestackPackage(getApplicationContext())
+            new FirestackPackage()
       );
     }
   };
diff --git a/android/src/main/java/io/fullstack/firestack/FirestackPackage.java b/android/src/main/java/io/fullstack/firestack/FirestackPackage.java
@@ -15,8 +15,7 @@
 public class FirestackPackage implements ReactPackage {
     private Context mContext;
 
-    public FirestackPackage(Context ctx) {
-        mContext = ctx;
+    public FirestackPackage() {
     }
     /**
      * @param reactContext react application context that can be used to create modules
@@ -26,7 +25,7 @@ public FirestackPackage(Context ctx) {
     public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
         List<NativeModule> modules = new ArrayList<>();
 
-        modules.add(new FirestackModule(reactContext, mContext));
+        modules.add(new FirestackModule(reactContext, reactContext.getBaseContext()));
         modules.add(new FirestackAuthModule(reactContext));
         modules.add(new FirestackDatabaseModule(reactContext));
         modules.add(new FirestackAnalyticsModule(reactContext));
diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
       "project": "ios/Firestack.xcodeproj"
     },
     "android": {
-      "packageInstance": "new FirestackPackage(getApplicationContext())"
+      "packageInstance": "new FirestackPackage()"
     }
   },
   "devDependencies": {

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ public class MainApplication extends Application implements ReactApplication {`
`144`	`144`	`protected List<ReactPackage> getPackages() {`
`145`	`145`	`return Arrays.<ReactPackage>asList(`
`146`	`146`	`new MainReactPackage(),`
`147`		`- new FirestackPackage(getApplicationContext())`
	`147`	`+ new FirestackPackage()`
`148`	`148`	`);`
`149`	`149`	`}`
`150`	`150`	`};`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@`
`47`	`47`	`"project": "ios/Firestack.xcodeproj"`
`48`	`48`	`},`
`49`	`49`	`"android": {`
`50`		`- "packageInstance": "new FirestackPackage(getApplicationContext())"`
	`50`	`+ "packageInstance": "new FirestackPackage()"`
`51`	`51`	`}`
`52`	`52`	`},`
`53`	`53`	`"devDependencies": {`