wifi: mac80211: fix memory leak in ieee80211_if_add()

zhengchaoshao · jmberg-intel · commit 13e5afd3d773 · 2022-12-01T13:50:41.000+01:00
When register_netdevice() failed in ieee80211_if_add(), ndev->tstats isn't released. Fix it. Fixes: 5a49051 ("mac80211: use per-CPU TX/RX statistics") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Link: https://lore.kernel.org/r/20221117064500.319983-1-shaozhengchao@huawei.com Signed-off-by: Johannes Berg <johannes.berg@intel.com>
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
@@ -2195,6 +2195,7 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,
 
 		ret = cfg80211_register_netdevice(ndev);
 		if (ret) {
+			ieee80211_if_free(ndev);
 			free_netdev(ndev);
 			return ret;
 		}

Original file line number	Diff line number	Diff line change
`@@ -2195,6 +2195,7 @@ int ieee80211_if_add(struct ieee80211_local local, const char name,`
`2195`	`2195`
`2196`	`2196`	`ret = cfg80211_register_netdevice(ndev);`
`2197`	`2197`	`if (ret) {`
	`2198`	`+ ieee80211_if_free(ndev);`
`2198`	`2199`	`free_netdev(ndev);`
`2199`	`2200`	`return ret;`
`2200`	`2201`	`}`