Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 635b643

Browse files
etpinardetpinard
committed
move @gl in 'describe' to child 'it'
1 parent a8c6217 commit 635b643

12 files changed

+171
-171
lines changed

‎test/jasmine/tests/cone_test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ describe('Test cone defaults', function() {
6060
});
6161
});
6262

63-
describe('@gl Test cone autorange:', function() {
63+
describe('Test cone autorange:', function() {
6464
var gd;
6565

6666
beforeEach(function() {
@@ -79,7 +79,7 @@ describe('@gl Test cone autorange:', function() {
7979
expect(sceneLayout.zaxis.range).toBeCloseToArray(zrng, 2, 'zaxis range - ' + msg);
8080
}
8181

82-
it('should add pad around cone position to make sure they fit on the scene', function(done) {
82+
it('@gl should add pad around cone position to make sure they fit on the scene', function(done) {
8383
var fig = Lib.extendDeep({}, require('@mocks/gl3d_cone-autorange.json'));
8484
var rng0 = [0.103, 3.897];
8585

@@ -177,7 +177,7 @@ describe('@gl Test cone autorange:', function() {
177177
});
178178
});
179179

180-
describe('@gl Test cone interactions', function() {
180+
describe('Test cone interactions', function() {
181181
var gd;
182182

183183
beforeEach(function() {
@@ -189,7 +189,7 @@ describe('@gl Test cone interactions', function() {
189189
destroyGraphDiv();
190190
});
191191

192-
it('should add/clear gl objects correctly', function(done) {
192+
it('@gl should add/clear gl objects correctly', function(done) {
193193
var fig = Lib.extendDeep({}, require('@mocks/gl3d_cone-simple.json'));
194194
// put traces on same subplot
195195
delete fig.data[1].scene;
@@ -219,7 +219,7 @@ describe('@gl Test cone interactions', function() {
219219
.then(done);
220220
});
221221

222-
it('should not pass zero or infinite `coneSize` to gl-cone3d', function(done) {
222+
it('@gl should not pass zero or infinite `coneSize` to gl-cone3d', function(done) {
223223
var base = {
224224
type: 'cone',
225225
x: [1, 2, 3],
@@ -254,7 +254,7 @@ describe('@gl Test cone interactions', function() {
254254
.then(done);
255255
});
256256

257-
it('should display hover labels', function(done) {
257+
it('@gl should display hover labels', function(done) {
258258
var fig = Lib.extendDeep({}, require('@mocks/gl3d_cone-simple.json'));
259259
// only one trace on one scene
260260
fig.data = [fig.data[0]];
@@ -302,7 +302,7 @@ describe('@gl Test cone interactions', function() {
302302
.then(done);
303303
});
304304

305-
it('should display hover labels (multi-trace case)', function(done) {
305+
it('@gl should display hover labels (multi-trace case)', function(done) {
306306
function _hover() {
307307
mouseEvent('mouseover', 282, 240);
308308
return delay(20)();

‎test/jasmine/tests/gl2d_click_test.js

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ var mock4 = {
6666
layout: {}
6767
};
6868

69-
describe('@gl @flaky Test hover and click interactions', function() {
69+
describe('@flaky Test hover and click interactions', function() {
7070
var gd;
7171

7272
function makeHoverFn(gd, x, y) {
@@ -185,7 +185,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
185185
destroyGraphDiv();
186186
});
187187

188-
it('should output correct event data for scattergl', function(done) {
188+
it('@gl should output correct event data for scattergl', function(done) {
189189
var _mock = Lib.extendDeep({}, mock1);
190190

191191
_mock.layout.hoverlabel = {
@@ -222,7 +222,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
222222
.then(done);
223223
});
224224

225-
it('should output correct event data for scattergl in *select* dragmode', function(done) {
225+
it('@gl should output correct event data for scattergl in *select* dragmode', function(done) {
226226
var _mock = Lib.extendDeep({}, mock1);
227227

228228
_mock.layout.dragmode = 'select';
@@ -261,7 +261,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
261261
.then(done);
262262
});
263263

264-
it('should output correct event data for scattergl in *lasso* dragmode', function(done) {
264+
it('@gl should output correct event data for scattergl in *lasso* dragmode', function(done) {
265265
var _mock = Lib.extendDeep({}, mock1);
266266

267267
_mock.layout.dragmode = 'lasso';
@@ -300,7 +300,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
300300
.then(done);
301301
});
302302

303-
it('should output correct event data for scattergl with hoverinfo: \'none\'', function(done) {
303+
it('@gl should output correct event data for scattergl with hoverinfo: \'none\'', function(done) {
304304
var _mock = Lib.extendDeep({}, mock1);
305305
_mock.data[0].hoverinfo = 'none';
306306

@@ -320,7 +320,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
320320
.then(done);
321321
});
322322

323-
it('should show correct label for scattergl when hovertext is set', function(done) {
323+
it('@gl should show correct label for scattergl when hovertext is set', function(done) {
324324
var _mock = Lib.extendDeep({}, mock1);
325325
_mock.data[0].hovertext = 'text';
326326
_mock.data[0].hovertext = 'HoVeRtExT';
@@ -347,7 +347,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
347347
.then(done);
348348
});
349349

350-
it('should output correct event data for pointcloud', function(done) {
350+
it('@gl should output correct event data for pointcloud', function(done) {
351351
var _mock = Lib.extendDeep({}, mock2);
352352

353353
_mock.layout.hoverlabel = { font: {size: 8} };
@@ -375,7 +375,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
375375
.then(done);
376376
});
377377

378-
it('should output correct event data for heatmapgl', function(done) {
378+
it('@gl should output correct event data for heatmapgl', function(done) {
379379
var _mock = Lib.extendDeep({}, mock3);
380380
_mock.data[0].type = 'heatmapgl';
381381

@@ -408,7 +408,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
408408
.then(done);
409409
});
410410

411-
it('should output correct event data for heatmapgl (asymmetric case) ', function(done) {
411+
it('@gl should output correct event data for heatmapgl (asymmetric case) ', function(done) {
412412
var _mock = {
413413
data: [{
414414
type: 'heatmapgl',
@@ -441,7 +441,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
441441
.then(done);
442442
});
443443

444-
it('should output correct event data for scattergl after visibility restyle', function(done) {
444+
it('@gl should output correct event data for scattergl after visibility restyle', function(done) {
445445
var _mock = Lib.extendDeep({}, mock4);
446446

447447
var run = makeRunner([435, 216], {
@@ -483,7 +483,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
483483
.then(done);
484484
});
485485

486-
it('should output correct event data for scattergl-fancy', function(done) {
486+
it('@gl should output correct event data for scattergl-fancy', function(done) {
487487
var _mock = Lib.extendDeep({}, mock4);
488488
_mock.data[0].mode = 'markers+lines';
489489
_mock.data[1].mode = 'markers+lines';
@@ -531,7 +531,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
531531
.then(done);
532532
});
533533

534-
it('should output correct event data contourgl', function(done) {
534+
it('@gl should output correct event data contourgl', function(done) {
535535
var _mock = Lib.extendDeep({}, mock3);
536536

537537
_mock.data[0].hoverlabel = {
@@ -560,7 +560,7 @@ describe('@gl @flaky Test hover and click interactions', function() {
560560
});
561561
});
562562

563-
describe('@noCI @gl Test gl2d lasso/select:', function() {
563+
describe('@noCI Test gl2d lasso/select:', function() {
564564
var mockFancy = require('@mocks/gl2d_14.json');
565565
delete mockFancy.layout.xaxis.autorange;
566566
delete mockFancy.layout.yaxis.autorange;
@@ -630,7 +630,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
630630
}
631631

632632

633-
it('should work under fast mode with *select* dragmode', function(done) {
633+
it('@gl should work under fast mode with *select* dragmode', function(done) {
634634
var _mock = Lib.extendDeep({}, mockFast);
635635
_mock.layout.dragmode = 'select';
636636
gd = createGraphDiv();
@@ -657,7 +657,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
657657
.then(done);
658658
});
659659

660-
it('should work under fast mode with *lasso* dragmode', function(done) {
660+
it('@gl should work under fast mode with *lasso* dragmode', function(done) {
661661
var _mock = Lib.extendDeep({}, mockFast);
662662
_mock.layout.dragmode = 'lasso';
663663
gd = createGraphDiv();
@@ -681,7 +681,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
681681
.then(done);
682682
});
683683

684-
it('should work under fancy mode with *select* dragmode', function(done) {
684+
it('@gl should work under fancy mode with *select* dragmode', function(done) {
685685
var _mock = Lib.extendDeep({}, mockFancy);
686686
_mock.layout.dragmode = 'select';
687687
gd = createGraphDiv();
@@ -701,7 +701,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
701701
.then(done);
702702
});
703703

704-
it('should work under fancy mode with *lasso* dragmode', function(done) {
704+
it('@gl should work under fancy mode with *lasso* dragmode', function(done) {
705705
var _mock = Lib.extendDeep({}, mockFancy);
706706
_mock.layout.dragmode = 'lasso';
707707
gd = createGraphDiv();
@@ -720,7 +720,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
720720
.then(done);
721721
});
722722

723-
it('should work on trace with enabled transforms', function(done) {
723+
it('@gl should work on trace with enabled transforms', function(done) {
724724
var fig = Lib.extendDeep({}, require('@mocks/gl2d_transforms.json'));
725725
fig.layout.dragmode = 'select';
726726
fig.layout.margin = {t: 0, b: 0, l: 0, r: 0};
@@ -743,7 +743,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
743743
.then(done);
744744
});
745745

746-
it('should work on gl text charts', function(done) {
746+
it('@gl should work on gl text charts', function(done) {
747747
var fig = Lib.extendDeep({}, require('@mocks/gl2d_text_chart_basic.json'));
748748
fig.layout.dragmode = 'select';
749749
fig.layout.margin = {t: 0, b: 0, l: 0, r: 0};
@@ -826,7 +826,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
826826
.then(done);
827827
});
828828

829-
it('should work on gl text charts with array textfont.color', function(done) {
829+
it('@gl should work on gl text charts with array textfont.color', function(done) {
830830
var fig = Lib.extendDeep({}, require('@mocks/gl2d_text_chart_arrays.json'));
831831
fig.layout.dragmode = 'select';
832832
fig.layout.margin = {t: 0, b: 0, l: 0, r: 0};
@@ -906,7 +906,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
906906
.then(done);
907907
});
908908

909-
it('should work after a width/height relayout', function(done) {
909+
it('@gl should work after a width/height relayout', function(done) {
910910
gd = createGraphDiv();
911911

912912
var w = 500;
@@ -965,7 +965,7 @@ describe('@noCI @gl Test gl2d lasso/select:', function() {
965965
.then(done);
966966
});
967967

968-
it('should behave correctly during select+doubleclick+pan scenarios', function(done) {
968+
it('@gl should behave correctly during select+doubleclick+pan scenarios', function(done) {
969969
gd = createGraphDiv();
970970

971971
// See https://github.com/plotly/plotly.js/issues/2767

‎test/jasmine/tests/gl2d_date_axis_render_test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var Plotly = require('@lib');
33
var createGraphDiv = require('../assets/create_graph_div');
44
var destroyGraphDiv = require('../assets/destroy_graph_div');
55

6-
describe('@gl date axis', function() {
6+
describe('date axis', function() {
77

88
var gd;
99

@@ -13,7 +13,7 @@ describe('@gl date axis', function() {
1313

1414
afterEach(destroyGraphDiv);
1515

16-
it('should use the fancy gl-vis/gl-scatter2d', function() {
16+
it('@gl should use the fancy gl-vis/gl-scatter2d', function() {
1717
Plotly.plot(gd, [{
1818
type: 'scattergl',
1919
'marker': {
@@ -40,7 +40,7 @@ describe('@gl date axis', function() {
4040
expect(scene.line2d).not.toBeUndefined();
4141
});
4242

43-
it('should use the fancy gl-vis/gl-scatter2d once again', function() {
43+
it('@gl should use the fancy gl-vis/gl-scatter2d once again', function() {
4444
Plotly.plot(gd, [{
4545
type: 'scattergl',
4646
'marker': {
@@ -66,7 +66,7 @@ describe('@gl date axis', function() {
6666
expect(scene.line2d).toBeDefined();
6767
});
6868

69-
it('should now use the non-fancy gl-vis/gl-scatter2d', function() {
69+
it('@gl should now use the non-fancy gl-vis/gl-scatter2d', function() {
7070
Plotly.plot(gd, [{
7171
type: 'scattergl',
7272
mode: 'markers',
@@ -85,7 +85,7 @@ describe('@gl date axis', function() {
8585
expect(scene.line2d).toBeDefined();
8686
});
8787

88-
it('should use the non-fancy gl-vis/gl-scatter2d with string dates', function() {
88+
it('@gl should use the non-fancy gl-vis/gl-scatter2d with string dates', function() {
8989
Plotly.plot(gd, [{
9090
type: 'scattergl',
9191
mode: 'markers',

0 commit comments

Comments
 (0)