Add a local flag that can prevent the adapter (redis) from publishing… #2628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the emit to the pub\sub server
Contributor
Author
|
Works with this pull request: |
Member
|
Thanks! |
darrachequesne
pushed a commit
that referenced
this pull request
Apr 27, 2018
To match the behaviour on the namespace (see #2628).
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
That new flag will prevent the adapter (redis) from publishing the emit to the pub/sub server. When several instances of a server receive the same event from a third party (not from a client), each server instance broadcasts the event to all his clients. With the local flag, and the change in the redis adapter, each server instance send the event only to his client, so each client receive only one unique event.
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
To match the behaviour on the namespace (see socketio#2628).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the emit to the pub\sub server