Support binary encoding in the client for more performance.

mcollina · mcollina · commit d19af3bd469d · 2013-09-16T09:47:15.000+02:00
diff --git a/benchmarks/throughputCounter.js b/benchmarks/throughputCounter.js
@@ -2,7 +2,7 @@
 
 var mqtt = require('../');
 
-var client = mqtt.createClient(1883);
+var client = mqtt.createClient(1883, { encoding: 'binary' });
 var counter = 0;
 var interval = 15000;
 
diff --git a/lib/client.js b/lib/client.js
@@ -143,7 +143,7 @@ MqttClient.prototype._setupStream = function() {
   this.stream = this.streamBuilder();
 
   // MqttConnection
-  this.conn = this.stream.pipe(new Connection());
+  this.conn = this.stream.pipe(new Connection( { encoding: this.options.encoding }));
 
   // Set encoding of incoming publish payloads
   if (this.options.encoding) {
diff --git a/test/abstract_client.js b/test/abstract_client.js
@@ -494,6 +494,33 @@ module.exports = function(server, createClient, port) {
       });
     });
 
+    it('should support binary data', function(done) {
+      var client = createClient(port, { encoding: 'binary' })
+        , testPacket = {
+            topic: 'test',
+            payload: 'message',
+            retain: true,
+            qos: 1,
+            messageId: 5
+          };
+
+      client.subscribe(testPacket.topic);
+      client.once('message', 
+          function(topic, message, packet) {
+        topic.should.equal(testPacket.topic);
+        message.should.be.an.instanceOf(Buffer);
+        message.toString().should.equal(testPacket.payload);
+        packet.should.equal(packet);
+        done();
+      });
+
+      server.once('client', function(client) {
+        client.on('subscribe', function(packet) {
+          client.publish(testPacket);
+        });
+      });
+    });
+
     it('should emit a message event (qos=2)', function(done) {
       var client = createClient(port)
         , testPacket = {
