-
Notifications
You must be signed in to change notification settings - Fork 92
solarwinds/orionsdk-python fix - updating setup.cfg to use underscore #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solarwinds/orionsdk-python fix - updating setup.cfg to use underscore #83
Conversation
… in description_file per pypa/setuptools#4910
|
@danjagnow can you review this? This prevents new installs as of the setuptools removal of the long-deprecated configuration |
|
@danjagnow following up, this issue prevents package installation/usage |
|
@MichalLudik @akumetsu183 is there another maintainer that can get involved in this Solarwinds-owned repository? |
|
@FliesLikeABrick thank you for raising this. I have cross posted to the Thwack community https://thwack.solarwinds.com/products/the-solarwinds-platform/f/solarwinds-sdk/105448/backlog-of-pull-requests-for-python-module |
|
Hello @FliesLikeABrick, it looks like that the modern approach is slightly different, |
bfecd71 to
9d74da3
Compare
|
@MichalLudik please review now, I have made that update |
jakub-drzyzga-swi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made few formatting fixes to setup.cfg and removed long_description from setup.py - thanks for the contribution! Will go ahead and merge now.
solarwinds/orionsdk-python fix - updating setup.cfg to use underscorein description_file per pypa/setuptools#4910