_sonata_admin is used

as attribute for lot of routes
as query params for some routes like appendFormFieldElement or getShortObjectDescription
as request param in RetrieveAutocompleteItems

In the same way, all the data in retrieve autocomplete items action seems to be passed in the request: _context, field, q, ... And I wonder if the $request->query->get($reqParamPageNumber, '1') is not wrong.
Also, it's seems to be the only route where data is passed in the request instead of the query. Even appendFormFieldElement or SetObjectFieldValue or RetrieveFormFieldElement which are made by POST are passing all the data in the query.

In the controller, $request->get($this->admin->getIdParameter()); could be replaced by $request->attribute->get($this->admin->getIdParameter()); and calls like $request->get('btn_preview') could use $request->request instead.

Also, the #7185 issue is showing that sometimes id or parentId are passed as query params instead of attributes so in the AbtractAdmin $this->getRequest()->get($parentAdmin->getIdParameter()) should check the attributes AND the query params.

I find over 60 usage of the get method, and most of them will need at least attributes->get(...) ?? query->get(...) or even attributes->get(...) ?? query->get(...) ?? request->get(...) ; so we won't gain a lot over the usage of this internal method.

Did you plan to make a poc @franmomu ?
Should we really try to stop using the internal method ?
Should we implement a static utils method then which does the same ? I don't think it's great to duplicate the symfony method...

Any thought @jordisala1991 ?

Uh oh!

Remove the usage of Request::get #7365

Description

Feature Request

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions

Remove the usage of `Request::get` #7365