Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Render membranes between compartments in QMeshRenderer #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Render membranes between compartments in QMeshRenderer #1054

merged 1 commit into from
Feb 21, 2025

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Feb 20, 2025

  • QMeshRenderer
    • add membranes as vtkPolyData of vtkCellArray
    • add setMembraneIndex method
  • Mesh3d
    • add membraneIdColorPairs to constructor
    • provide triangles for each membrane
    • calculate hsv-interpolated color between the two compartment colors for membranes
  • resolves display membranes in QMeshRenderer #1033

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.89189% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.52%. Comparing base (99b3df2) to head (16b8ee5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gui/tabs/tabgeometry.cpp 68.75% 5 Missing ⚠️
core/mesh/src/mesh3d.cpp 95.16% 3 Missing ⚠️
core/model/src/model_geometry.cpp 60.00% 2 Missing ⚠️
gui/widgets/qmeshrenderer.cpp 96.92% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   90.51%   90.52%   +0.01%     
==========================================
  Files         130      130              
  Lines       13676    13780     +104     
==========================================
+ Hits        12379    12475      +96     
- Misses       1297     1305       +8
Flag Coverage Δ
cli 19.97% <0.00%> (-0.17%) ⬇️
core 48.64% <40.00%> (-0.03%) ⬇️
gui 67.01% <91.89%> (+0.20%) ⬆️
mainwindow 40.34% <1.38%> (-0.31%) ⬇️
sme 33.26% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan force-pushed the fix_1033_display_membranes_in_mesh_view branch from 434ccfa to 7475224 Compare February 20, 2025 14:01
@lkeegan
Render membranes between compartments in QMeshRenderer
16b8ee5 
- QMeshRenderer
  - add membranes as vtkPolyData of vtkCellArray
  - add setMembraneIndex method
- Mesh3d
  - add membraneIdColorPairs to constructor
  - provide triangles for each membrane
  - calculate hsv-interpolated color between the two compartment colors for membranes
- resolves #1033
@lkeegan lkeegan force-pushed the fix_1033_display_membranes_in_mesh_view branch from 7475224 to 16b8ee5 Compare February 21, 2025 11:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lkeegan lkeegan merged commit 6ae654a into main Feb 21, 2025
22 checks passed
@lkeegan lkeegan deleted the fix_1033_display_membranes_in_mesh_view branch February 21, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

display membranes in QMeshRenderer
1 participant
@lkeegan