Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] simplify the CI workflows by leveraging UV features #13519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

No description provided.

@danieleades danieleades force-pushed the workflow-simplification branch 2 times, most recently from 00c8097 to ba7f973 Compare April 28, 2025 12:41
@danieleades
Copy link
Contributor Author

@AA-Turner take a look at these test failures - https://github.com/sphinx-doc/sphinx/actions/runs/14708083075/job/41273149792?pr=13519

i guess this is because UV is resolving a different environment than the pip-based interface was before, which really highlights the need to commit lockfiles

run: uv pip install --upgrade "docutils~=${{ matrix.docutils }}.0"
run: uv pip install --upgrade "docutils~=${{ matrix.docutils }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional, so that the job names say "(Docutils 0.20)" etc.

Comment on lines -57 to +53
- name: Install dependencies
run: uv pip install -r pyproject.toml --group package --group test --group types
- name: Type check with mypy
run: mypy
run: uv run mypy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which packages does uv install here? Does it pick up the dependency groups automatically?

Copy link
Contributor Author

@danieleades danieleades Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is skipping the fine-grained dependency groups. This could be re-added but the micro optimisation just didn't seem worth the complexity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact, given UV resolves the dependencies damn near instantly, i'd be in favour of collapsing these groups into something much more simple

@danieleades danieleades force-pushed the workflow-simplification branch from 5259987 to 95b740a Compare April 28, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants