From e95def26e6c1aa980c6eeb6e5699992ef3eee04d Mon Sep 17 00:00:00 2001 From: Mauro Antonio Sanz Date: Wed, 21 May 2025 19:03:32 -0300 Subject: [PATCH 1/2] fix HttpSplitFetcher --- .../main/java/io/split/client/HttpSplitChangeFetcher.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java b/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java index 3659af9f..83f51488 100644 --- a/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java +++ b/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java @@ -40,7 +40,7 @@ public final class HttpSplitChangeFetcher implements SplitChangeFetcher { private static final String SETS = "sets"; private static final String SPEC = "s"; private String specVersion = SPEC_1_3; - private int PROXY_CHECK_INTERVAL_MILLISECONDS_SS = 24 * 60 * 60 * 1000; + private int PROXY_CHECK_INTERVAL_MILLISECONDS_SS = 60000;//24 * 60 * 60 * 1000; private Long _lastProxyCheckTimestamp = 0L; private final SplitHttpClient _client; private final URI _target; @@ -70,11 +70,13 @@ long makeRandomTill() { public SplitChange fetch(long since, long sinceRBS, FetchOptions options) { long start = System.currentTimeMillis(); try { + URI uri = buildURL(options, since, sinceRBS); if (specVersion.equals(SPEC_1_1) && (System.currentTimeMillis() - _lastProxyCheckTimestamp >= PROXY_CHECK_INTERVAL_MILLISECONDS_SS)) { _log.info("Switching to new Feature flag spec ({}) and fetching.", SPEC_1_3); specVersion = SPEC_1_3; + uri = buildURL(options, -1,-1); } - URI uri = buildURL(options, since, sinceRBS); + SplitHttpResponse response = _client.get(uri, options, null); if (response.statusCode() < HttpStatus.SC_OK || response.statusCode() >= HttpStatus.SC_MULTIPLE_CHOICES) { if (response.statusCode() == HttpStatus.SC_REQUEST_URI_TOO_LONG) { From 4ae42b9a0571eacde8330b8bd84ee2db42e5aa31 Mon Sep 17 00:00:00 2001 From: Mauro Antonio Sanz Date: Wed, 21 May 2025 19:07:06 -0300 Subject: [PATCH 2/2] undo changes --- .../src/main/java/io/split/client/HttpSplitChangeFetcher.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java b/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java index 83f51488..c74adff5 100644 --- a/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java +++ b/client/src/main/java/io/split/client/HttpSplitChangeFetcher.java @@ -40,7 +40,7 @@ public final class HttpSplitChangeFetcher implements SplitChangeFetcher { private static final String SETS = "sets"; private static final String SPEC = "s"; private String specVersion = SPEC_1_3; - private int PROXY_CHECK_INTERVAL_MILLISECONDS_SS = 60000;//24 * 60 * 60 * 1000; + private int PROXY_CHECK_INTERVAL_MILLISECONDS_SS = 24 * 60 * 60 * 1000; private Long _lastProxyCheckTimestamp = 0L; private final SplitHttpClient _client; private final URI _target;