bug fix for a bug reported by nightman (RuntimeError: maximum recursion depth exceeded)

stamparm · stamparm · commit 042e3f76ba6f · 2011-01-05T11:36:40.000Z
diff --git a/lib/request/basicauthhandler.py b/lib/request/basicauthhandler.py
@@ -16,7 +16,7 @@ class SmartHTTPBasicAuthHandler(urllib2.HTTPBasicAuthHandler):
     """
     def __init__(self, *args, **kwargs):
         urllib2.HTTPBasicAuthHandler.__init__(self, *args, **kwargs)
-        self.retried_req = None
+        self.retried_req = []
 
     def reset_retry_count(self):
         # Python 2.6.5 will call this on 401 or 407 errors and thus loop
@@ -26,8 +26,8 @@ def reset_retry_count(self):
 
     def http_error_auth_reqed(self, auth_header, host, req, headers):
         # Reset the retry counter once for each request.
-        if req is not self.retried_req:
-            self.retried_req = req
+        if req not in self.retried_req:
+            self.retried_req.append(req)
             self.retried = 0
         return urllib2.HTTPBasicAuthHandler.http_error_auth_reqed(
                         self, auth_header, host, req, headers)
