Fix for an Issue #415

stamparm · stamparm · commit 084cfc797ad6 · 2013-03-02T09:55:12.000+01:00
diff --git a/lib/core/dump.py b/lib/core/dump.py
@@ -379,11 +379,11 @@ def dbTableValues(self, tableValues):
             self._write(tableValues, content_type=CONTENT_TYPE.DUMP_TABLE)
             return
 
+        dumpDbPath = "%s%s%s" % (conf.dumpPath, os.sep, unsafeSQLIdentificatorNaming(db))
+
         if conf.dumpFormat == DUMP_FORMAT.SQLITE:
             replication = Replication("%s%s%s.sqlite3" % (conf.dumpPath, os.sep, unsafeSQLIdentificatorNaming(db)))
         elif conf.dumpFormat in (DUMP_FORMAT.CSV, DUMP_FORMAT.HTML):
-            dumpDbPath = "%s%s%s" % (conf.dumpPath, os.sep, unsafeSQLIdentificatorNaming(db))
-
             if not os.path.isdir(dumpDbPath):
                 os.makedirs(dumpDbPath, 0755)
 
@@ -522,6 +522,9 @@ def dbTableValues(self, tableValues):
                     if len(value) > MIN_BINARY_DISK_DUMP_SIZE and r'\x' in value:
                         mimetype = magic.from_buffer(value, mime=True)
                         if any(mimetype.startswith(_) for _ in ("application", "image")):
+                            if not os.path.isdir(dumpDbPath):
+                                os.makedirs(dumpDbPath, 0755)
+
                             filepath = os.path.join(dumpDbPath, "%s-%d.bin" % (column, randomInt(8)))
                             warnMsg = "writing binary ('%s') content to file '%s' " % (mimetype, filepath)
                             logger.warn(warnMsg)
