Tamper function(s) refactoring (really no need for returning headers as they are passed by reference)

stamparm · stamparm · commit 12fc9442b92e · 2012-10-25T10:10:23.000+02:00
diff --git a/lib/core/agent.py b/lib/core/agent.py
@@ -48,7 +48,7 @@ def payloadDirect(self, query):
 
         if kb.tamperFunctions:
             for function in kb.tamperFunctions:
-                query, _ = function(payload=query, headers=None)
+                query = function(payload=query)
 
         return query
 
diff --git a/lib/request/connect.py b/lib/request/connect.py
@@ -587,7 +587,7 @@ def queryPage(value=None, place=None, content=False, getRatioValue=False, silent
         if payload:
             if kb.tamperFunctions:
                 for function in kb.tamperFunctions:
-                    payload, auxHeaders = function(payload=payload, headers=auxHeaders)
+                    payload = function(payload=payload, headers=auxHeaders)
 
                 value = agent.replacePayload(value, payload)
 
diff --git a/tamper/apostrophemask.py b/tamper/apostrophemask.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces apostrophe character with its UTF-8 full width counterpart
 
@@ -27,4 +27,4 @@ def tamper(payload, headers):
         * http://lukasz.pilorz.net/testy/full_width_utf/index.phps
     """
 
-    return payload.replace('\'', "%EF%BC%87") if payload else payload, headers
+    return payload.replace('\'', "%EF%BC%87") if payload else payload
diff --git a/tamper/apostrophenullencode.py b/tamper/apostrophenullencode.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces apostrophe character with its illegal double unicode counterpart
 
@@ -21,4 +21,4 @@ def tamper(payload, headers):
         * Output: AND %00%271%00%27=%00%271%00%27
     """
 
-    return payload.replace('\'', "%00%27") if payload else payload, headers
+    return payload.replace('\'', "%00%27") if payload else payload
diff --git a/tamper/appendnullbyte.py b/tamper/appendnullbyte.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Appends encoded NULL byte character at the end of payload
 
@@ -31,4 +31,4 @@ def tamper(payload, headers):
     Reference: http://projects.webappsec.org/w/page/13246949/Null-Byte-Injection
     """
 
-    return "%s%%00" % payload if payload else payload, headers
+    return "%s%%00" % payload if payload else payload
diff --git a/tamper/base64encode.py b/tamper/base64encode.py
@@ -14,7 +14,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Base64 all characters in a given payload
 
@@ -23,4 +23,4 @@ def tamper(payload, headers):
         * Output: MScgQU5EIFNMRUVQKDUpIw==
     """
 
-    return base64.b64encode(payload) if payload else payload, headers
+    return base64.b64encode(payload) if payload else payload
diff --git a/tamper/between.py b/tamper/between.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces greater than operator ('>') with 'NOT BETWEEN 0 AND #'
 
@@ -61,4 +61,4 @@ def tamper(payload, headers):
 
             retVal += payload[i]
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/chardoubleencode.py b/tamper/chardoubleencode.py
@@ -14,7 +14,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Double url-encodes all characters in a given payload (not processing
     already encoded)
@@ -43,4 +43,4 @@ def tamper(payload, headers):
                 retVal += '%%25%.2X' % ord(payload[i])
                 i += 1
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/charencode.py b/tamper/charencode.py
@@ -14,7 +14,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Url-encodes all characters in a given payload (not processing already
     encoded)
@@ -50,4 +50,4 @@ def tamper(payload, headers):
                 retVal += '%%%.2X' % ord(payload[i])
                 i += 1
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/charunicodeencode.py b/tamper/charunicodeencode.py
@@ -16,7 +16,7 @@
 def dependencies():
     singleTimeWarnMessage("tamper script '%s' is only meant to be run against ASP or ASP.NET web applications" % os.path.basename(__file__).split(".")[0])
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Unicode-url-encodes non-encoded characters in a given payload (not
     processing already encoded)
@@ -55,4 +55,4 @@ def tamper(payload, headers):
                 retVal += '%%u%.4X' % ord(payload[i])
                 i += 1
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/equaltolike.py b/tamper/equaltolike.py
@@ -17,7 +17,7 @@
 def dependencies():
     singleTimeWarnMessage("tamper script '%s' is unlikely to work against %s" % (os.path.basename(__file__).split(".")[0], DBMS.PGSQL))
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces all occurances of operator equal ('=') with operator 'LIKE'
 
@@ -47,4 +47,4 @@ def process(match):
     if payload:
         retVal = re.sub(r"\s*=\s*", lambda match: process(match), retVal)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/halfversionedmorekeywords.py b/tamper/halfversionedmorekeywords.py
@@ -1,8 +1,6 @@
 #!/usr/bin/env python
 
 """
-$Id$
-
 Copyright (c) 2006-2012 sqlmap developers (http://sqlmap.org/)
 See the file 'doc/COPYING' for copying permission
 """
@@ -21,7 +19,7 @@
 def dependencies():
     singleTimeWarnMessage("tamper script '%s' is only meant to be run against %s < 5.1" % (os.path.basename(__file__).split(".")[0], DBMS.MYSQL))
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Adds versioned MySQL comment before each keyword
 
@@ -55,4 +53,4 @@ def process(match):
         retVal = re.sub(r"(?<=\W)(?P<word>[A-Za-z_]+)(?=\W|\Z)", lambda match: process(match), retVal)
         retVal = retVal.replace(" /*!0", "/*!0")
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/ifnull2ifisnull.py b/tamper/ifnull2ifisnull.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces instances like 'IFNULL(A, B)' with 'IF(ISNULL(A), B, A)'
 
@@ -61,4 +61,4 @@ def tamper(payload, headers):
             else:
                 break
 
-    return payload, headers
+    return payload
diff --git a/tamper/modsecurityversioned.py b/tamper/modsecurityversioned.py
@@ -13,7 +13,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Embraces complete query with versioned comment
 
@@ -43,4 +43,4 @@ def tamper(payload, headers):
         if ' ' in payload:
             retVal = "%s /*!30%s%s*/%s" % (payload[:payload.find(' ')], randomInt(3), payload[payload.find(' ') + 1:], postfix)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/modsecurityzeroversioned.py b/tamper/modsecurityzeroversioned.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Embraces complete query with zero-versioned comment
 
@@ -42,4 +42,4 @@ def tamper(payload, headers):
         if ' ' in payload:
             retVal = "%s /*!00000%s*/%s" % (payload[:payload.find(' ')], payload[payload.find(' ') + 1:], postfix)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/multiplespaces.py b/tamper/multiplespaces.py
@@ -16,7 +16,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Adds multiple spaces around SQL keywords
 
@@ -46,4 +46,4 @@ def tamper(payload, headers):
             retVal = re.sub("(?<=\W)%s(?=[^A-Za-z_(]|\Z)" % word, "%s%s%s" % (' '*random.randrange(1,4), word, ' '*random.randrange(1,4)), retVal)
             retVal = re.sub("(?<=\W)%s(?=[(])" % word, "%s%s" % (' '*random.randrange(1,4), word), retVal)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/nonrecursivereplacement.py b/tamper/nonrecursivereplacement.py
@@ -13,7 +13,7 @@
 
 __priority__ = PRIORITY.NORMAL
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces predefined SQL keywords with representations
     suitable for replacement (e.g. .replace("SELECT", "")) filters
@@ -38,4 +38,4 @@ def tamper(payload, headers):
             _ = random.randint(1, len(keyword) - 1)
             retVal = re.sub(r"(?i)\b%s\b" % keyword, "%s%s%s" % (keyword[:_], keyword, keyword[_:]), retVal)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/percentage.py b/tamper/percentage.py
@@ -16,7 +16,7 @@
 def dependencies():
     singleTimeWarnMessage("tamper script '%s' is only meant to be run against ASP web applications" % os.path.basename(__file__).split(".")[0])
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Adds a percentage sign ('%') infront of each character
 
@@ -51,4 +51,4 @@ def tamper(payload, headers):
                 retVal += payload[i]
                 i += 1
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/randomcase.py b/tamper/randomcase.py
@@ -16,7 +16,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces each keyword character with random case value
 
@@ -50,4 +50,4 @@ def tamper(payload, headers):
 
                 retVal = retVal.replace(word, _)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/randomcomments.py b/tamper/randomcomments.py
@@ -13,7 +13,7 @@
 
 __priority__ = PRIORITY.LOW
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Add random comments to SQL keywords
     Example: 'INSERT' becomes 'IN/**/S/**/ERT'
@@ -37,4 +37,4 @@ def tamper(payload, headers):
                 _ += word[-1]
                 retVal = retVal.replace(word, _)
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/securesphere.py b/tamper/securesphere.py
@@ -14,7 +14,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Appends special crafted string
 
@@ -27,4 +27,4 @@ def tamper(payload, headers):
         * Reference: http://seclists.org/fulldisclosure/2011/May/163
     """
 
-    return payload + " and '0having'='0having'" if payload else payload, headers
+    return payload + " and '0having'='0having'" if payload else payload
diff --git a/tamper/sp_password.py b/tamper/sp_password.py
@@ -9,7 +9,7 @@
 
 __priority__ = PRIORITY.HIGH
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Appends 'sp_password' to the end of the payload for automatic obfuscation from DBMS logs
 
@@ -30,4 +30,4 @@ def tamper(payload, headers):
     if payload:
         retVal = "%s%ssp_password" % (payload, "-- " if not any(_ if _ in payload else None for _ in ('#', "-- ")) else "")
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/space2comment.py b/tamper/space2comment.py
@@ -12,7 +12,7 @@
 def dependencies():
     pass
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces space character (' ') with comments '/**/'
 
@@ -55,4 +55,4 @@ def tamper(payload, headers):
 
             retVal += payload[i]
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/space2dash.py b/tamper/space2dash.py
@@ -12,7 +12,7 @@
 
 __priority__ = PRIORITY.LOW
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces space character (' ') with a dash comment ('--') followed by
     a random string and a new line ('\n')
@@ -46,4 +46,4 @@ def tamper(payload, headers):
             else:
                 retVal += payload[i]
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/space2hash.py b/tamper/space2hash.py
@@ -18,7 +18,7 @@
 def dependencies():
     singleTimeWarnMessage("tamper script '%s' is only meant to be run against %s" % (os.path.basename(__file__).split(".")[0], DBMS.MYSQL))
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces space character (' ') with a pound character ('#') followed by
     a random string and a new line ('\n')
@@ -52,4 +52,4 @@ def tamper(payload, headers):
             else:
                 retVal += payload[i]
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/space2morehash.py b/tamper/space2morehash.py
@@ -21,7 +21,7 @@
 def dependencies():
     singleTimeWarnMessage("tamper script '%s' is only meant to be run against %s > 5.1.13" % (os.path.basename(__file__).split(".")[0], DBMS.MYSQL))
 
-def tamper(payload, headers):
+def tamper(payload, headers=None):
     """
     Replaces space character (' ') with a pound character ('#') followed by
     a random string and a new line ('\n')
@@ -66,4 +66,4 @@ def process(match):
             else:
                 retVal += payload[i]
 
-    return retVal, headers
+    return retVal
diff --git a/tamper/space2mssqlblank.py b/tamper/space2mssqlblank.py
diff --git a/tamper/space2mssqlhash.py b/tamper/space2mssqlhash.py
diff --git a/tamper/space2mysqlblank.py b/tamper/space2mysqlblank.py
diff --git a/tamper/space2mysqldash.py b/tamper/space2mysqldash.py
diff --git a/tamper/space2plus.py b/tamper/space2plus.py
diff --git a/tamper/space2randomblank.py b/tamper/space2randomblank.py
diff --git a/tamper/unionalltounion.py b/tamper/unionalltounion.py
diff --git a/tamper/unmagicquotes.py b/tamper/unmagicquotes.py
diff --git a/tamper/versionedkeywords.py b/tamper/versionedkeywords.py
diff --git a/tamper/versionedmorekeywords.py b/tamper/versionedmorekeywords.py
