Minor enhancement to be able to dump entries also on MySQL < 5.0 when DB name, table name and column(s) are provided

bdamele · bdamele · commit 342a5436f4f8 · 2008-10-26T17:07:55.000Z
diff --git a/plugins/generic/enumeration.py b/plugins/generic/enumeration.py
@@ -784,11 +784,6 @@ def getColumns(self, onlyColNames=False):
 
 
     def dumpTable(self):
-        if kb.dbms == "MySQL" and not self.has_information_schema:
-            errMsg  = "information_schema not available, "
-            errMsg += "back-end DBMS is MySQL < 5.0"
-            raise sqlmapUnsupportedFeatureException, errMsg
-
         if not conf.tbl:
             errMsg = "missing table parameter"
             raise sqlmapMissingMandatoryOptionException, errMsg
@@ -804,27 +799,32 @@ def dumpTable(self):
 
         rootQuery = queries[kb.dbms].dumpTable
 
-        logMsg = "fetching"
-        if conf.col:
-            colList = conf.col.split(",")
-            colString = ", ".join(column for column in colList)
-            logMsg += " columns '%s'" % colString
-        logMsg += " entries for table '%s'" % conf.tbl
-        logMsg += " on database '%s'" % conf.db
-        logger.info(logMsg)
-
         if conf.col:
             self.cachedColumns[conf.db] = {}
             self.cachedColumns[conf.db][conf.tbl] = {}
             for column in colList:
                 self.cachedColumns[conf.db][conf.tbl][column] = None
         elif not self.cachedColumns:
+            if kb.dbms == "MySQL" and not self.has_information_schema:
+                errMsg  = "information_schema not available, "
+                errMsg += "back-end DBMS is MySQL < 5.0"
+                raise sqlmapUnsupportedFeatureException, errMsg
+
             self.cachedColumns = self.getColumns(onlyColNames=True)
 
         colList = self.cachedColumns[conf.db][conf.tbl].keys()
         colList.sort(key=lambda x: x.lower())
         colString = ", ".join(column for column in colList)
 
+        logMsg = "fetching"
+        if conf.col:
+            colList = conf.col.split(",")
+            colString = ", ".join(column for column in colList)
+            logMsg += " columns '%s'" % colString
+        logMsg += " entries for table '%s'" % conf.tbl
+        logMsg += " on database '%s'" % conf.db
+        logger.info(logMsg)
+
         if conf.unionUse:
             if kb.dbms == "Oracle":
                 query = rootQuery["inband"]["query"] % (colString, conf.tbl.upper())
