Patch for an Issue #711

stamparm · stamparm · commit 54be398e838f · 2014-06-04T16:35:07.000+02:00
diff --git a/lib/core/common.py b/lib/core/common.py
@@ -1045,9 +1045,6 @@ def setPaths():
     paths.SQLMAP_XML_BANNER_PATH = os.path.join(paths.SQLMAP_XML_PATH, "banner")
     paths.SQLMAP_OUTPUT_PATH = paths.get("SQLMAP_OUTPUT_PATH", os.path.join(paths.SQLMAP_ROOT_PATH, "output"))
 
-    if not os.access(paths.SQLMAP_OUTPUT_PATH, os.W_OK):
-        paths.SQLMAP_OUTPUT_PATH = os.path.join(os.path.expanduser("~"), ".sqlmap", "output")
-
     paths.SQLMAP_DUMP_PATH = os.path.join(paths.SQLMAP_OUTPUT_PATH, "%s", "dump")
     paths.SQLMAP_FILES_PATH = os.path.join(paths.SQLMAP_OUTPUT_PATH, "%s", "files")
 
diff --git a/lib/core/target.py b/lib/core/target.py
@@ -14,6 +14,7 @@
 import urlparse
 
 from lib.core.common import Backend
+from lib.core.common import getUnicode
 from lib.core.common import hashDBRetrieve
 from lib.core.common import intersect
 from lib.core.common import paramToDict
@@ -513,15 +514,22 @@ def _createTargetDirs():
         try:
             os.makedirs(paths.SQLMAP_OUTPUT_PATH, 0755)
         except OSError, ex:
-            tempDir = tempfile.mkdtemp(prefix="sqlmapoutput")
-            warnMsg = "unable to create default root output directory "
-            warnMsg += "'%s' (%s). " % (paths.SQLMAP_OUTPUT_PATH, ex)
-            warnMsg += "Using temporary directory '%s' instead" % tempDir
-            logger.warn(warnMsg)
-
-            paths.SQLMAP_OUTPUT_PATH = tempDir
-
-    conf.outputPath = os.path.join(paths.SQLMAP_OUTPUT_PATH, conf.hostname)
+            paths.SQLMAP_OUTPUT_PATH = os.path.join(os.path.expanduser("~"), ".sqlmap", "output")
+            try:
+                if not os.path.isdir(paths.SQLMAP_OUTPUT_PATH):
+                    os.makedirs(paths.SQLMAP_OUTPUT_PATH, 0755)
+                warnMsg = "using '%s' as the output directory" % paths.SQLMAP_OUTPUT_PATH
+                logger.warn(warnMsg)
+            except OSError, ex:    
+                tempDir = tempfile.mkdtemp(prefix="sqlmapoutput")
+                warnMsg = "unable to create regular output directory "
+                warnMsg += "'%s' (%s). " % (paths.SQLMAP_OUTPUT_PATH, ex)
+                warnMsg += "Using temporary directory '%s' instead" % tempDir
+                logger.warn(warnMsg)
+
+                paths.SQLMAP_OUTPUT_PATH = tempDir
+
+    conf.outputPath = os.path.join(paths.SQLMAP_OUTPUT_PATH, getUnicode(conf.hostname))
 
     if not os.path.isdir(conf.outputPath):
         try:
diff --git a/sqlmap.py b/sqlmap.py
@@ -83,10 +83,6 @@ def main():
         dataToStdout("[!] legal disclaimer: %s\n\n" % LEGAL_DISCLAIMER, forceOutput=True)
         dataToStdout("[*] starting at %s\n\n" % time.strftime("%X"), forceOutput=True)
 
-        if ".sqlmap" in paths.SQLMAP_OUTPUT_PATH:
-            warnMsg = "using '%s' as the output directory" % paths.SQLMAP_OUTPUT_PATH
-            logger.warn(warnMsg)
-
         init()
 
         if conf.profile:
