Avoid to check for existence of not needed UDFs and minor code adjustment for cleanup() method

bdamele · bdamele · commit 5c92fad5dccc · 2010-02-05T23:14:16.000Z
diff --git a/lib/takeover/abstraction.py b/lib/takeover/abstraction.py
@@ -46,18 +46,6 @@ def __init__(self):
         Web.__init__(self)
         xp_cmdshell.__init__(self)
 
-    def __cmdShellCleanup(self):
-        if not conf.cleanup:
-            if kb.dbms in ( "MySQL", "PostgreSQL" ):
-                self.cleanup()
-
-            elif kb.dbms == "Microsoft SQL Server":
-                self.cleanup(onlyFileTbl=True)
-
-            else:
-                errMsg = "Feature not yet implemented for the back-end DBMS"
-                raise sqlmapUnsupportedFeatureException, errMsg
-
     def execCmd(self, cmd, silent=False, forgeCmd=False):
         if self.webBackdoorUrl and not kb.stackedTest:
             self.webBackdoorRunCmd(cmd)
@@ -103,9 +91,6 @@ def runCmd(self, cmd):
         else:
             self.execCmd(cmd, forgeCmd=True)
 
-        if not conf.osShell and not conf.osPwn and not conf.cleanup:
-            self.__cmdShellCleanup()
-
     def shell(self):
         if self.webBackdoorUrl and not kb.stackedTest:
             infoMsg  = "calling OS shell. To quit type "
@@ -157,8 +142,6 @@ def shell(self):
 
             self.runCmd(command)
 
-        self.__cmdShellCleanup()
-
     def initEnv(self, mandatory=True, detailed=False, web=False):
         if self.envInitialized:
             return
diff --git a/lib/takeover/udf.py b/lib/takeover/udf.py
@@ -116,6 +116,13 @@ def udfEvalCmd(self, cmd, first=None, last=None, udfName=None):
 
         return output
 
+    def checkNeededUdfs(self):
+        if not conf.osPwn:
+            self.sysUdfs.pop("sys_bineval")
+
+        if not conf.osCmd and not conf.osShell and not conf.regRead:
+            self.sysUdfs.pop("sys_eval")
+
     def udfCreateFromSharedLib(self):
         errMsg = "udfSetRemotePath() method must be defined within the plugin"
         raise sqlmapUnsupportedFeatureException(errMsg)
diff --git a/plugins/dbms/mysql.py b/plugins/dbms/mysql.py
@@ -560,6 +560,7 @@ def udfInjectCmd(self):
             self.udfLocalFile   += "/mysql/linux/lib_mysqludf_sys.so"
             self.udfSharedLibExt = "so"
 
+        self.checkNeededUdfs()
         self.udfInjectCore(self.sysUdfs)
         
     def uncPathRequest(self):
diff --git a/plugins/dbms/postgresql.py b/plugins/dbms/postgresql.py
@@ -469,6 +469,7 @@ def udfInjectCmd(self):
             self.udfLocalFile += "/postgresql/linux/%s/lib_postgresqludf_sys.so" % majorVer
             self.udfSharedLibExt = "so"
 
+        self.checkNeededUdfs()
         self.udfInjectCore(self.sysUdfs)
 
     def uncPathRequest(self):
diff --git a/plugins/generic/takeover.py b/plugins/generic/takeover.py
@@ -100,6 +100,9 @@ def osCmd(self):
         if not web or (web and self.webBackdoorUrl is not None):
             self.runCmd(conf.osCmd)
 
+        if not conf.osShell and not conf.osPwn and not conf.cleanup:
+            self.cleanup()
+
     def osShell(self):
         stackedTest()
 
@@ -120,6 +123,9 @@ def osShell(self):
         if not web or (web and self.webBackdoorUrl is not None):
             self.shell()
 
+        if not conf.osPwn and not conf.cleanup:
+            self.cleanup()
+
     def osPwn(self):
         goUdf = False
 
@@ -228,6 +234,9 @@ def osPwn(self):
         if not web or (web and self.webBackdoorUrl is not None):
             self.pwn(goUdf)
 
+        if not conf.cleanup:
+            self.cleanup()
+
     def osSmb(self):
         stackedTest()
 
