Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 8fc6021

Browse files
committed
lol. this was a pesky bug. heuristic wasn't working on one mssql test site and i couldn't find why. at end the problem was that when the HTTP code was raised (like 500) no parseResponse was called.
1 parent 7c06dbf commit 8fc6021

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

lib/controller/checks.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,8 @@ def heuristicCheckSqlInjection(place, parameter, value):
444444

445445
payload = "%s%s%s%s" % (value, prefix, randomStr(length=10, alphabet=['"', '\'', ')', '(']), suffix)
446446
payload = agent.payload(place, parameter, value, payload)
447-
page, _ = Request.queryPage(payload, place, content=True, raise404=False)
447+
Request.queryPage(payload, place, content=False, raise404=False)
448+
448449
result = wasLastRequestDBMSError()
449450

450451
infoMsg = "heuristic test shows that %s " % place

lib/request/connect.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ def getPage(**kwargs):
266266
else:
267267
debugMsg = "got HTTP error code: %d (%s)" % (code, status)
268268
logger.debug(debugMsg)
269+
parseResponse(page, responseHeaders)
269270
return page, responseHeaders
270271

271272
except (urllib2.URLError, socket.error, socket.timeout, httplib.BadStatusLine, httplib.IncompleteRead), e:

xml/errors.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<error regexp="OLE DB.*SQL Server"/>
2424
<error regexp="SQL Server.*Driver"/>
2525
<error regexp="Warning.*mssql_.*"/>
26+
<error regexp="SQL Server.*[0-9a-fA-F]{8}"/>
2627
</dbms>
2728

2829
<!-- Microsoft Access -->

0 commit comments

Comments
 (0)