Major bug fix following the last commit

bdamele · bdamele · commit 989533863037 · 2008-10-27T23:56:02.000Z
diff --git a/lib/request/connect.py b/lib/request/connect.py
@@ -77,24 +77,27 @@ def getPage(**kwargs):
                 params = urlencode(params).replace("%%", "%")
                 url = "%s?%s" % (url, params)
                 requestMsg += "?%s" % params
+
         elif multipart:
                 multipartOpener = urllib2.build_opener(multipartpost.MultipartPostHandler)
                 conn = multipartOpener.open(url, multipart)
                 page = conn.read()
                 return page
-        elif conf.method in ( "GET", "POST" ):
+
+        else:
             if conf.parameters.has_key("GET") and not get:
                 get = conf.parameters["GET"]
 
             if get:
                 get = urlencode(get).replace("%%", "%")
                 url = "%s?%s" % (url, get)
                 requestMsg += "?%s" % get
-        elif conf.method == "POST":
-            if conf.parameters.has_key("POST") and not post:
-                post = conf.parameters["POST"]
 
-            post = urlencode(post).replace("%%", "%")
+            if conf.method == "POST":
+                if conf.parameters.has_key("POST") and not post:
+                    post = conf.parameters["POST"]
+
+                post = urlencode(post).replace("%%", "%")
 
         requestMsg += " HTTP/1.1"
 
@@ -107,7 +110,7 @@ def getPage(**kwargs):
             req            = urllib2.Request(url, post, headers)
             conn           = urllib2.urlopen(req)
 
-            if "Accept-Encoding" not in req.headers:
+            if not req.has_header("Accept-Encoding"):
                 requestHeaders += "\nAccept-Encoding: identity"
 
             requestHeaders = "\n".join(["%s: %s" % (header, value) for header, value in req.header_items()])
@@ -121,10 +124,10 @@ def getPage(**kwargs):
 
                 cookieStr += "%s; " % cookie[8:index]
 
-            if "Cookie" not in req.headers and cookieStr:
+            if not req.has_header("Cookie") and cookieStr:
                 requestHeaders += "\n%s" % cookieStr[:-2]
      
-            if "Connection" not in req.headers:
+            if not req.has_header("Connection"):
                 requestHeaders += "\nConnection: close"
 
             requestMsg += "\n%s" % requestHeaders
