Minor improvement (safer to use column name in COUNT than *, especially when only one column is needed)

stamparm · stamparm · commit a40d7a5bca1a · 2012-11-15T15:06:54.000+01:00
diff --git a/lib/techniques/error/use.py b/lib/techniques/error/use.py
@@ -306,7 +306,7 @@ def errorUse(expression, dump=False):
                     stopLimit = conf.limitStop
 
             # Count the number of SQL query entries output
-            countedExpression = expression.replace(expressionFields, queries[Backend.getIdentifiedDbms()].count.query % '*', 1)
+            countedExpression = expression.replace(expressionFields, queries[Backend.getIdentifiedDbms()].count.query % ('*' if len(expressionFieldsList) > 1 else expressionFields), 1)
 
             if " ORDER BY " in expression:
                 countedExpression = countedExpression[:countedExpression.index(" ORDER BY ")]
diff --git a/lib/techniques/union/use.py b/lib/techniques/union/use.py
@@ -233,7 +233,7 @@ def unionUse(expression, unpack=True, dump=False):
                     stopLimit = conf.limitStop
 
             # Count the number of SQL query entries output
-            countedExpression = expression.replace(expressionFields, queries[Backend.getIdentifiedDbms()].count.query % '*', 1)
+            countedExpression = expression.replace(expressionFields, queries[Backend.getIdentifiedDbms()].count.query % ('*' if len(expressionFieldsList) > 1 else expressionFields), 1)
 
             if " ORDER BY " in countedExpression.upper():
                 _ = countedExpression.upper().rindex(" ORDER BY ")
