Fix for an Issue #323

stamparm · stamparm · commit a77b7f00d92e · 2012-12-23T19:34:35.000+01:00
diff --git a/lib/takeover/metasploit.py b/lib/takeover/metasploit.py
@@ -5,7 +5,6 @@
 See the file 'doc/COPYING' for copying permission
 """
 
-import codecs
 import os
 import re
 import sys
@@ -531,7 +530,7 @@ def createMsfShellcode(self, exitfunc, format, extra, encode):
             errMsg = "failed to create the shellcode (%s)" % payloadStderr.replace("\n", " ").replace("\r", "")
             raise SqlmapFilePathException, errMsg
 
-        self._shellcodeFP = codecs.open(self._shellcodeFilePath, "rb", UNICODE_ENCODING)
+        self._shellcodeFP = open(self._shellcodeFilePath, "rb")
         self.shellcodeString = self._shellcodeFP.read()
         self._shellcodeFP.close()
 
diff --git a/plugins/dbms/mssqlserver/filesystem.py b/plugins/dbms/mssqlserver/filesystem.py
@@ -5,7 +5,6 @@
 See the file 'doc/COPYING' for copying permission
 """
 
-import codecs
 import ntpath
 import os
 
@@ -23,7 +22,6 @@
 from lib.core.enums import PAYLOAD
 from lib.core.exception import SqlmapNoneDataException
 from lib.core.exception import SqlmapUnsupportedFeatureException
-from lib.core.settings import UNICODE_ENCODING
 from lib.request import inject
 
 from plugins.generic.filesystem import Filesystem as GenericFilesystem
@@ -338,9 +336,8 @@ def stackedWriteFile(self, wFile, dFile, fileType):
 
         tmpPath = posixToNtSlashes(conf.tmpPath)
         dFile = posixToNtSlashes(dFile)
-        wFilePointer = codecs.open(wFile, "rb", UNICODE_ENCODING)
-        wFileContent = wFilePointer.read()
-        wFilePointer.close()
+        with open(wFile, "rb") as f:
+            wFileContent = f.read()
 
         self._stackedWriteFileVbs(tmpPath, wFileContent, dFile, fileType)
 
diff --git a/plugins/generic/filesystem.py b/plugins/generic/filesystem.py
@@ -5,7 +5,6 @@
 See the file 'doc/COPYING' for copying permission
 """
 
-import codecs
 import os
 
 from lib.core.agent import agent
@@ -25,7 +24,6 @@
 from lib.core.enums import EXPECTED
 from lib.core.enums import PAYLOAD
 from lib.core.exception import SqlmapUndefinedMethod
-from lib.core.settings import UNICODE_ENCODING
 from lib.request import inject
 
 class Filesystem:
@@ -113,7 +111,7 @@ def fileEncode(self, fileName, encoding, single):
         """
 
         retVal = []
-        with codecs.open(fileName, "rb", UNICODE_ENCODING) as f:
+        with open(fileName, "rb") as f:
             content = f.read().encode(encoding).replace("\n", "")
 
         if not single:
