minor refactoring, issue #51

bdamele · bdamele · commit b7d2680e55b9 · 2012-07-02T12:50:26.000+01:00
diff --git a/lib/takeover/xp_cmdshell.py b/lib/takeover/xp_cmdshell.py
@@ -76,10 +76,9 @@ def __xpCmdshellConfigure2000(self, mode):
         logger.debug(debugMsg)
 
         if mode == 1:
-            cmd = "EXEC master..sp_addextendedproc 'xp_cmdshell', "
-            cmd += "@dllname='xplog70.dll'"
+            cmd = getSPQLSnippet(DBMS.MSSQL, "enable_xp_cmdshell_2000", ENABLE=str(mode))
         else:
-            cmd = "EXEC master..sp_dropextendedproc 'xp_cmdshell'"
+            cmd = getSPQLSnippet(DBMS.MSSQL, "disable_xp_cmdshell_2000", ENABLE=str(mode))
 
         return cmd
 
diff --git a/procs/mssqlserver/disable_xp_cmdshell_2000.txt b/procs/mssqlserver/disable_xp_cmdshell_2000.txt
@@ -0,0 +1 @@
+EXEC master..sp_dropextendedproc 'xp_cmdshell';
diff --git a/procs/mssqlserver/enable_xp_cmdshell_2000.txt b/procs/mssqlserver/enable_xp_cmdshell_2000.txt
@@ -0,0 +1 @@
+EXEC master..sp_addextendedproc 'xp_cmdshell', @dllname='xplog70.dll';

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+EXEC master..sp_dropextendedproc 'xp_cmdshell';`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+EXEC master..sp_addextendedproc 'xp_cmdshell', @dllname='xplog70.dll';`