Bug fixes for search (safeStringFormat should not replace all if given scalar values)

stamparm · stamparm · commit e83662921551 · 2013-02-05T11:37:49.000+01:00
diff --git a/lib/core/common.py b/lib/core/common.py
@@ -1374,9 +1374,9 @@ def safeStringFormat(format_, params):
     retVal = format_.replace("%d", "%s")
 
     if isinstance(params, basestring):
-        retVal = retVal.replace("%s", params)
+        retVal = retVal.replace("%s", params, 1)
     elif not isListLike(params):
-        retVal = retVal.replace("%s", str(params))
+        retVal = retVal.replace("%s", str(params), 1)
     else:
         count, index = 0, 0
         while index != -1:
diff --git a/plugins/generic/search.py b/plugins/generic/search.py
@@ -314,7 +314,7 @@ def searchTable(self):
                             query = agent.limitQuery(index, query)
 
                         foundTbl = unArrayizeValue(inject.getValue(query, union=False, error=False))
-                        if not isNoneValue(foundTbls[db]):
+                        if not isNoneValue(foundTbl):
                             kb.hintValue = foundTbl
                             foundTbl = safeSQLIdentificatorNaming(foundTbl, True)
                             foundTbls[db].append(foundTbl)
