bug fix for --os-shell on Windows (echo ... > requires double quotes if the piped filename contains whitespace, otherwise doesn't hurt)

stamparm · stamparm · commit edeb4b61132f · 2012-02-15T11:14:01.000Z
diff --git a/lib/takeover/xp_cmdshell.py b/lib/takeover/xp_cmdshell.py
@@ -114,7 +114,7 @@ def xpCmdshellEvalCmd(self, cmd, first=None, last=None):
         self.getRemoteTempPath()
 
         tmpFile = "%s/tmpc%s.txt" % (conf.tmpPath, randomStr(lowercase=True))
-        cmd = "%s > %s" % (cmd, tmpFile)
+        cmd = "%s > \"%s\"" % (cmd, tmpFile)
 
         self.xpCmdshellExecCmd(cmd)
 
